After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787987 - xdmcp-display-factory: more signal prototype fixing
xdmcp-display-factory: more signal prototype fixing
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-21 13:23 UTC by Ray Strode [halfline]
Modified: 2017-09-21 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
xdmcp-display-factory: more signal prototype fixing (6.24 KB, patch)
2017-09-21 13:23 UTC, Ray Strode [halfline]
committed Details | Review

Description Ray Strode [halfline] 2017-09-21 13:23:45 UTC
commit 2a3d5a7c402534c3611956fed930394a51cb00c5 attempted to fix
the signal prototype of on_client_disconnected to match the marshalled
arguments.  Unfortunately, the handler is used for two different
signals:

1) when a user chooses "Disconnect" from the chooser menu
2) when a user closes the Xephyr window (or turns off the thin client
or whatever)

The signals have slightly different prototypes, so commit 2a3d5a7c
fixed 2), but broke 1).

This commit massages the signal connections and handler signature to
work for both cases.
Comment 1 Ray Strode [halfline] 2017-09-21 13:23:52 UTC
Created attachment 360197 [details] [review]
xdmcp-display-factory: more signal prototype fixing
Comment 2 Ray Strode [halfline] 2017-09-21 13:24:11 UTC
Attachment 360197 [details] pushed as 8629209 - xdmcp-display-factory: more signal prototype fixing