GNOME Bugzilla – Bug 787965
Totem uses debian-specific utility "pycompile" for building
Last modified: 2017-09-21 19:06:52 UTC
In recent meson port, Totem started using pycompile, which is a Debian specific utility. The build toolchain should only use upstream Python or Meson tools or self-contained scripts. Why is pycompile even necessary? What does it do compared to `python -m compileall` called on the next line of meson_compile_python.py? compileall seems sufficient to produce pyc files.
Created attachment 360204 [details] [review] Remove pycompile utility (In reply to Jan Tojnar from comment #0) > In recent meson port, Totem started using pycompile, which is a Debian > specific utility. The build toolchain should only use upstream Python or > Meson tools or self-contained scripts. > > Why is pycompile even necessary? What does it do compared to `python -m > compileall` called on the next line of meson_compile_python.py? compileall > seems sufficient to produce pyc files. You are totally right. This patch reverts this situation and uses the Python binary for both optimized and non-optimized compilations. Totem was my first ~big program~ port to meson, by using vala, python, etc... I will like to make a come back to this meson port someday.
Review of attachment 360204 [details] [review]: Sure, thanks.
Review of attachment 360204 [details] [review]: Looks good to me, assuming you’ve tested that compilation still works.
Comment on attachment 360204 [details] [review] Remove pycompile utility Pushed as 39f82f0a - build: Remove pycompile utility
(In reply to Philip Withnall from comment #3) > Review of attachment 360204 [details] [review] [review]: > > Looks good to me, assuming you’ve tested that compilation still works. Thanks. Yes I have verified that it compiles and that the result is as expected. Still, I'd like to check the port again.