After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787965 - Totem uses debian-specific utility "pycompile" for building
Totem uses debian-specific utility "pycompile" for building
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
3.26.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-09-20 22:35 UTC by Jan Tojnar
Modified: 2017-09-21 19:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove pycompile utility (1.17 KB, patch)
2017-09-21 17:14 UTC, Iñigo Martínez
committed Details | Review

Description Jan Tojnar 2017-09-20 22:35:45 UTC
In recent meson port, Totem started using pycompile, which is a Debian specific utility. The build toolchain should only use upstream Python or Meson tools or self-contained scripts.

Why is pycompile even necessary? What does it do compared to `python -m compileall` called on the next line of meson_compile_python.py? compileall seems sufficient to produce pyc files.
Comment 1 Iñigo Martínez 2017-09-21 17:14:44 UTC
Created attachment 360204 [details] [review]
Remove pycompile utility

(In reply to Jan Tojnar from comment #0)
> In recent meson port, Totem started using pycompile, which is a Debian
> specific utility. The build toolchain should only use upstream Python or
> Meson tools or self-contained scripts.
> 
> Why is pycompile even necessary? What does it do compared to `python -m
> compileall` called on the next line of meson_compile_python.py? compileall
> seems sufficient to produce pyc files.

You are totally right. This patch reverts this situation and uses the Python binary for both optimized and non-optimized compilations.

Totem was my first ~big program~ port to meson, by using vala, python, etc... I will like to make a come back to this meson port someday.
Comment 2 Bastien Nocera 2017-09-21 18:09:34 UTC
Review of attachment 360204 [details] [review]:

Sure, thanks.
Comment 3 Philip Withnall 2017-09-21 18:11:33 UTC
Review of attachment 360204 [details] [review]:

Looks good to me, assuming you’ve tested that compilation still works.
Comment 4 Iñigo Martínez 2017-09-21 19:03:15 UTC
Comment on attachment 360204 [details] [review]
Remove pycompile utility

Pushed as 39f82f0a - build: Remove pycompile utility
Comment 5 Iñigo Martínez 2017-09-21 19:06:52 UTC
(In reply to Philip Withnall from comment #3)
> Review of attachment 360204 [details] [review] [review]:
> 
> Looks good to me, assuming you’ve tested that compilation still works.

Thanks. Yes I have verified that it compiles and that the result is as expected. Still, I'd like to check the port again.