GNOME Bugzilla – Bug 787951
Improve help system
Last modified: 2017-10-03 18:53:32 UTC
Right now, you need to have a manual for your exact language installed. If not, GIMP just considers you have no manual installed. If you have a manual installed in another language, it won't be used. This is bad first because we have manuals in only 17 languages (whereas GIMP has 80 localizations) so there may not even be a manual in your GUI localization anyway. In this case, you may choose to use a manual in another language you know. My proposition: - if GIMP finds a manual for your localization, loads it (as currently); - otherwise when the popup "The GIMP user manual is not installed on your computer" displays, it currently has 2 choices: read online or cancel. As a third choice, if manuals for other languages are installed, propose a droplist to select one of these. See: https://www.gimp.org/docs/
Adding 2.10 milestone because that's something I wanted to do for some time. Maybe Lionel will try and look into this.
First step. Mostly done but now I need to update the preferences because right now the only way to reset your choice is by editing the gimprc file. commit c2330f002d65b3f6318fd13aacede10a765eb236 Author: Jehan <jehan@girinstud.io> Date: Mon Sep 25 22:59:50 2017 +0200 Bug 787951 - improve help system. When the manual in your current language is not installed, yet other manuals are available, the help dialog will now propose either to read the manual online (as was already the case) or to select a manual in another language instead. This is even more important since we don't have as many manuals as localizations of GIMP. Therefore if one took the explicit step to install a manual in another language, it makes sense that means one may know the alternative language. As an example, we have 3 Chinese localizations (zh_CN|TW|HK) but only a zh_CN manual. I could definitely imagine someone with a zh_HK GUI to go for the zh_CN manual as a fallback. Or other languages even, whatever! This is a first step. Right now once one chose the alternative help language, it is not possible to reset it yet (except by editing "help-locales" in gimprc). The next step will be to add the settings in Help System preferences.
The manual language can now be configured in the Preferences too, showing the list of installed manuals. I may change a few implementation details here and there, but the base is here. Let's close as FIXED. commit 66081969783a58060deaacc320fba2fdc3802b2b Author: Jehan <jehan@girinstud.io> Date: Tue Oct 3 01:52:35 2017 +0200 app: reuse GimpLanguageComboBox to show available manual languages. Better factorize by reusing code rather than recreating a combo box which does basically the same thing. I only added a boolean parameter to retrieve only the sublist of manual language. It also takes advantage of the self-translated language names from initialization. app/widgets/gimphelp.c | 196 +++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------- app/widgets/gimphelp.h | 2 ++ app/widgets/gimplanguagecombobox.c | 4 +-- app/widgets/gimplanguagecombobox.h | 2 +- app/widgets/gimppropwidgets.c | 2 +- app/widgets/gimptranslationstore.c | 101 +++++++++++++++++++++++++++++++++++++++++++++++++++---- app/widgets/gimptranslationstore.h | 2 +- 7 files changed, 173 insertions(+), 136 deletions(-) commit 3061333fdbf0a08b0a3bf37e833fd9be8349d362 Author: Jehan <jehan@girinstud.io> Date: Tue Oct 3 20:47:06 2017 +0200 app: the manual language can now be customized through the Preferences. app/dialogs/preferences-dialog.c | 213 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------- app/widgets/gimphelp.c | 3 +- app/widgets/gimplanguagecombobox.c | 18 +++++++-- app/widgets/gimplanguagecombobox.h | 3 +- app/widgets/gimppropwidgets.c | 2 +- app/widgets/gimptranslationstore.c | 23 ++++++++++-- app/widgets/gimptranslationstore.h | 3 +- 7 files changed, 201 insertions(+), 64 deletions(-)