GNOME Bugzilla – Bug 787934
nativeWindowPlacement: Stop copying everything and the kitchen sink
Last modified: 2017-10-17 15:55:14 UTC
See patches.
Created attachment 360108 [details] [review] naturalWindowPlacement: Remove unused stuff
Created attachment 360109 [details] [review] naturalWindowPlacement: Don't copy relayout() function To move title captions to the top, we can simply apply a translation before calling the unmodified original function.
Created attachment 360110 [details] [review] nativeWindowPlacement: Handle captions-on-top settings changes Currently the injection to move title captions to the top depends on the value of the setting at the time the extension is enabled. Instead, do the injections unconditionally and query the setting inside the function to pick up settings changes.
Created attachment 360111 [details] [review] nativeWindowPlacement: Use custom strategy to hook into layout Instead of copying a long function for a single changed line, wrap the layout algorithm in a LayoutStrategy so the workspace code picks it up without modifications.
Attachment 360108 [details] pushed as a0cae3d - naturalWindowPlacement: Remove unused stuff Attachment 360109 [details] pushed as 97d1cbc - naturalWindowPlacement: Don't copy relayout() function Attachment 360110 [details] pushed as 778eebc - nativeWindowPlacement: Handle captions-on-top settings changes Attachment 360111 [details] pushed as ef99394 - nativeWindowPlacement: Use custom strategy to hook into layout