After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787907 - Fix a couple of JS warnings
Fix a couple of JS warnings
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-09-19 16:18 UTC by Florian Müllner
Modified: 2017-09-19 18:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix some more undefined property warnings (1.89 KB, patch)
2017-09-19 16:18 UTC, Florian Müllner 		committed Details | Review
autorunManager: Avoid access to non-existent array element (1.08 KB, patch)
2017-09-19 16:18 UTC, Florian Müllner 		committed Details | Review
windowManager: Remove excess parameter (915 bytes, patch)
2017-09-19 16:19 UTC, Florian Müllner 		committed Details | Review
dnd: Declare dragMonitors with var (776 bytes, patch)
2017-09-19 16:19 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2017-09-19 16:18:16 UTC 
See patches.
Comment 1 Florian Müllner 2017-09-19 16:18:20 UTC 
Created attachment 360065 [details] [review]
Fix some more undefined property warnings
Comment 2 Florian Müllner 2017-09-19 16:18:27 UTC 
Created attachment 360066 [details] [review]
autorunManager: Avoid access to non-existent array element
Comment 3 Florian Müllner 2017-09-19 16:19:34 UTC 
Created attachment 360067 [details] [review]
windowManager: Remove excess parameter
Comment 4 Florian Müllner 2017-09-19 16:19:42 UTC 
Created attachment 360068 [details] [review]
dnd: Declare dragMonitors with var

It is used outside the DND module itself.
Comment 5 Rui Matos 2017-09-19 17:55:53 UTC 
Review of attachment 360065 [details] [review]:

lgtm
Comment 6 Rui Matos 2017-09-19 18:01:37 UTC 
Review of attachment 360066 [details] [review]:

right
Comment 7 Rui Matos 2017-09-19 18:03:35 UTC 
Review of attachment 360067 [details] [review]:

++
Comment 8 Rui Matos 2017-09-19 18:04:47 UTC 
Review of attachment 360068 [details] [review]:

indeed
Comment 9 Florian Müllner 2017-09-19 18:08:01 UTC 
Attachment 360065 [details] pushed as ecddf1f - Fix some more undefined property warnings
Attachment 360066 [details] pushed as 2d11b5c - autorunManager: Avoid access to non-existent array element
Attachment 360067 [details] pushed as 5a414ff - windowManager: Remove excess parameter
Attachment 360068 [details] pushed as 80151a7 - dnd: Declare dragMonitors with var