After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787866 - Untranslated key labels in the Keyboard panel of Settings
Untranslated key labels in the Keyboard panel of Settings
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.22.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-09-19 00:21 UTC by Piotr Drąg
Modified: 2017-10-09 18:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gdk: use Unicode quotation marks in gen-keyname-table.pl (2.04 KB, patch)
2017-10-07 23:09 UTC, Piotr Drąg 		none Details | Review
gdk: Translate some more key names (2.51 KB, patch)
2017-10-07 23:09 UTC, Piotr Drąg 		committed Details | Review

Description Piotr Drąg 2017-09-19 00:21:15 UTC 
Some key labels in the default shortcuts list (right column) are untranslated:

Eject
Explorer
Calculator
Mail
WWW
Tools
Search
Comment 1 Sebastien Bacher 2017-09-19 13:29:57 UTC 
The key translations seem to come from gdk and it looks like they should be added to that list
https://git.gnome.org/browse/gtk+/tree/gdk/keynames-translate.txt

I would suggest reassigning to gtk
Comment 2 Matthias Clasen 2017-10-07 22:39:20 UTC 
yes, you need to add them there, and then run gen-keyname-table.pl, and attach the resulting patch here, please.
Comment 3 Piotr Drąg 2017-10-07 23:09:31 UTC 
Created attachment 361110 [details] [review]
gdk: use Unicode quotation marks in gen-keyname-table.pl

Commit 13998c55e757c28c7a80b5ad47f82ef62ee57bf6 changed the quotation marks in gdk/keyname-table.h, but not in the script which generates that file, so running the script was overwriting them.
Comment 4 Piotr Drąg 2017-10-07 23:09:53 UTC 
Created attachment 361111 [details] [review]
gdk: Translate some more key names

These are used in the Keyboard panel of GNOME Settings.
Comment 5 Matthias Clasen 2017-10-09 17:56:02 UTC 
Review of attachment 361111 [details] [review]:

sure, looks fine