After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787844 - attach modal dialogs OFF has no effect
attach modal dialogs OFF has no effect
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
3.26.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-09-18 15:17 UTC by corrado venturini
Modified: 2017-09-20 17:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot from my try (59.02 KB, image/png)
2017-09-18 15:17 UTC, corrado venturini
  Details
widgets: Correctly handle overrides for Ubuntu session (967 bytes, patch)
2017-09-20 15:37 UTC, Jeremy Bicha
committed Details | Review
widgets: Better handle overrides for GNOME Shell modes (1.26 KB, patch)
2017-09-20 17:51 UTC, Jeremy Bicha
committed Details | Review

Description corrado venturini 2017-09-18 15:17:16 UTC
Created attachment 359992 [details]
screenshot from my try

I Start dconf Editor, set /org/gnome/shell/overrides attach-modal-dialogs = false has no effect.
same problem also using gnome-tweak-tool

I already opened a bug in launchpad https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1717925
and i was invited to submit the same problem upstream. 

corrado@corrado-HP-p3-aa:~$ inxi -Fx
System:    Host: corrado-HP-p3-aa Kernel: 4.12.0-13-generic x86_64 bits: 64 gcc: 7.2.0
           Desktop: Gnome 3.26.0 (Gtk 3.22.19-0ubuntu1) Distro: Ubuntu Artful Aardvark (development branch)
Machine:   Device: laptop System: Hewlett-Packard product: HP 250 G3 Notebook PC v: 0991100000000000000600087 serial: N/A
           Mobo: Hewlett-Packard model: 2211 v: 86.49 serial: N/A UEFI: Insyde v: F.36 date: 12/18/2014
Battery    BAT1: charge: 23.4 Wh 100.0% condition: 23.4/23.4 Wh (100%) model: 13-42 OA03031 status: Full
CPU:       Dual core Intel Core i5-4210U (-HT-MCP-) arch: Haswell rev.1 cache: 3072 KB
           flags: (lm nx sse sse2 sse3 sse4_1 sse4_2 ssse3 vmx) bmips: 9577
           clock speeds: max: 2700 MHz 1: 799 MHz 2: 869 MHz 3: 889 MHz 4: 878 MHz
Graphics:  Card: Intel Haswell-ULT Integrated Graphics Controller bus-ID: 00:02.0
           Display Server: x11 (X.Org 1.19.3 ) driver: i915 Resolution: 1366x768@60.00hz
           OpenGL: renderer: Mesa DRI Intel Haswell Mobile version: 4.5 Mesa 17.2.0 Direct Render: Yes
Audio:     Card-1 Intel 8 Series HD Audio Controller driver: snd_hda_intel bus-ID: 00:1b.0
           Card-2 Intel Haswell-ULT HD Audio Controller driver: snd_hda_intel bus-ID: 00:03.0
           Sound: Advanced Linux Sound Architecture v: k4.12.0-13-generic
Network:   Card-1: Realtek RTL8101/2/6E PCI Express Fast/Gigabit Ethernet controller
           driver: r8169 v: 2.3LK-NAPI port: 3000 bus-ID: 08:00.0
           IF: enp8s0 state: down mac: 5c:b9:01:06:ba:ce
           Card-2: Ralink RT3290 Wireless 802.11n 1T/1R PCIe driver: rt2800pci v: 2.3.0 bus-ID: 09:00.0
           IF: wlo1 state: up mac: ac:d1:b8:82:03:5d
Drives:    HDD Total Size: 500.1GB (10.9% used)
           ID-1: /dev/sda model: ST500LT012 size: 500.1GB
Partition: ID-1: / size: 32G used: 5.6G (19%) fs: ext4 dev: /dev/sda3
           ID-2: swap-1 size: 4.29GB used: 0.00GB (0%) fs: swap dev: /dev/sda2
RAID:      No RAID devices: /proc/mdstat, md_mod kernel module present
Sensors:   System Temperatures: cpu: 44.0C mobo: 44.0C
           Fan Speeds (in rpm): cpu: N/A
Info:      Processes: 234 Uptime: 1:51 Memory: 1177.2/3880.1MB Init: systemd runlevel: 5 Gcc sys: N/A
           Client: Shell (bash 4.4.121) inxi: 2.3.37 
corrado@corrado-HP-p3-aa:~$
Comment 1 Florian Müllner 2017-09-18 16:00:32 UTC
Is that Ubuntu's modified session, or the upstream one?
Comment 2 corrado venturini 2017-09-18 17:58:10 UTC
Just Ubuntu as installed from Ubuntu 17.10 "Artful Aardvark" - Alpha amd64 (20170911) plus the updates of last days. Thanks.
Comment 3 Florian Müllner 2017-09-18 18:01:09 UTC
That session doesn't use the org.gnome.shell.overrides schema. Does

  gsettings set org.gnome.mutter attach-modal-dialogs false

work?
Comment 4 corrado venturini 2017-09-19 06:51:33 UTC
Yes it works fine, thanks a lot, should I pass this information to launchpad?  or open a bug to dconf editor?
thanks again.
Comment 5 Florian Müllner 2017-09-19 08:23:26 UTC
No, dconf is a low-level tool that has no knowledge about the meaning of a particular key and what setting it represents. gnome-tweak-tool on the other hand should handle this case, so reassigning.
Comment 6 Jeremy Bicha 2017-09-20 15:37:42 UTC
Created attachment 360139 [details] [review]
widgets: Correctly handle overrides for Ubuntu session

The Ubuntu session in 17.10 uses org.gnome.mutter
not org.gnome.shell.overrides
Comment 7 Jeremy Bicha 2017-09-20 15:38:48 UTC
Thank you for reporting this issue and helping to make GNOME better.

This bug will be fixed in Tweaks 3.26.1.

Attachment 360139 [details] pushed as a2dcdff - widgets: Correctly handle overrides for Ubuntu session
Comment 8 Florian Müllner 2017-09-20 15:40:44 UTC
Review of attachment 360139 [details] [review]:

::: gtweak/widgets.py
@@ +137,3 @@
         overridesSchema = "org.gnome.shell.extensions.classic-overrides"
         overridesFile = None
+    elif (_shell.mode == 'ubuntu'):

A better option would be to check for 'classic' and 'user', then fall back to the original schema. That would be distro-agnostic and matches the logic used in gnome-shell.
Comment 9 Jeremy Bicha 2017-09-20 17:51:42 UTC
Created attachment 360146 [details] [review]
widgets: Better handle overrides for GNOME Shell modes
Comment 10 Jeremy Bicha 2017-09-20 17:52:27 UTC
Comment on attachment 360146 [details] [review]
widgets: Better handle overrides for GNOME Shell modes

Attachment 360146 [details] pushed as 49f3d1f - widgets: Better handle overrides for GNOME Shell modes