After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787828 - Do not create fourth primary partition as extended partition
Do not create fourth primary partition as extended partition
Status: RESOLVED OBSOLETE
Product: gnome-disk-utility
Classification: Core
Component: general
3.26.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-disk-utility-maint
gnome-disk-utility-maint
Depends on:
Blocks:
 
 
Reported: 2017-09-18 11:46 UTC by Kai Lüke
Modified: 2018-05-24 10:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Set partition type for MBR partitions (2.69 KB, patch)
2017-11-14 15:17 UTC, Kai Lüke
committed Details | Review

Description Kai Lüke 2017-09-18 11:46:23 UTC
The forth (and last) primary partition is now (since when, maybe in UDisks?) automatically an extended partition. Either change UI or support to have a forth normal primary partition.
Comment 1 Kai Lüke 2017-11-13 11:23:44 UTC
Could reproduce with gdbus, so has to be tracked here:
https://github.com/storaged-project/udisks/issues/446
Comment 2 Kai Lüke 2017-11-14 15:17:44 UTC
Created attachment 363599 [details] [review]
Set partition type for MBR partitions

No partition type was passed and UDisks changed default behavior to create a logical partition in an extended partition if there are already three primary partitions.

Thus Disks needs to pass the partition type argument and not only
the MBR type marker.
Comment 3 Ondrej Holy 2017-11-15 08:31:00 UTC
Review of attachment 363599 [details] [review]:

Looks ok and works nicely, thanks! Probably worth to push it in the stable as well.

Just a note that the partition-type option and the type argument seems a bit redundant in the udisks API to me, but that's not our deal.
Comment 4 Kai Lüke 2017-11-15 11:36:54 UTC
Comment on attachment 363599 [details] [review]
Set partition type for MBR partitions

Thanks for looking on it.
The hexadecimal partition type is used as marker for MBR partitions and can be changed through "Edit partition…". In theory it is not strictly linked to being a primary, extended or logical partition, but there is one marker reserved for extended partitions and this used to be enough for UDisks to decide what to do.

Yes, for an update to the stable release it is needed to rewrite the patch (other source file, this here works only on the new format dialog), thus I'll leave this bug open.
Comment 5 GNOME Infrastructure Team 2018-05-24 10:41:59 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-disk-utility/issues/69.