After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787729 - Add translation context to "Reset" string
Add translation context to "Reset" string
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-15 14:59 UTC by Rafael Fontenelle
Modified: 2017-09-18 16:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ui: Add context to 'Reset' strings (2.26 KB, patch)
2017-09-17 07:58 UTC, Adrien Plazas 		committed Details | Review

Description Rafael Fontenelle 2017-09-15 14:59:30 UTC 
Currently, the string "Reset" is used by 3 files:
- data/ui/gamepad-configurer.ui
- data/ui/reset-gamepad-mapping-dialog.ui
- data/ui/resume-failed-dialog.ui

I assume that the first two files, it is redefine the configuration of the gamepad, while the last one is to restart the game as its resume failed.

However, for the translators only one string shows up for these 3 contexts, which might result in bad translation. For my native language, "Reset" in the first context (gamepad) should receive a different translation than the second (resume)

Please add context to the strings in order to improve translation, as mentioned in:
https://wiki.gnome.org/TranslationProject/DevGuidelines/Translation%20contexts
Comment 1 Adrien Plazas 2017-09-17 07:58:52 UTC 
Created attachment 359921 [details] [review]
ui: Add context to 'Reset' strings
Comment 2 Adrien Plazas 2017-09-17 08:01:19 UTC 
Thanks Rafael, is that kind of context sufficient?
Comment 3 Rafael Fontenelle 2017-09-17 20:01:36 UTC 
It is perfect! Thanks, Adrien!
Comment 4 Adrien Plazas 2017-09-18 08:27:31 UTC 
Attachment 359921 [details] pushed as c9c19fc - ui: Add context to 'Reset' strings
Comment 5 Piotr Drąg 2017-09-18 16:06:29 UTC 
I don’t think it’s necessary to push it to the stable branch — master is enough in my opinion.