After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787727 - player: cosmetic changes
player: cosmetic changes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal enhancement
: 1.12.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-15 13:34 UTC by Philippe Renon
Modified: 2017-09-16 08:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remove duplciate state_ret check in play internal (958 bytes, patch)
2017-09-15 13:35 UTC, Philippe Renon 		committed Details | Review
introduce helper method to remove seek source (3.36 KB, patch)
2017-09-15 13:36 UTC, Philippe Renon 		committed Details | Review

Description Philippe Renon 2017-09-15 13:34:31 UTC 
Two minor cosmetic changes. See attached patches.
Comment 1 Philippe Renon 2017-09-15 13:35:09 UTC 
Created attachment 359846 [details] [review]
remove duplciate state_ret check in play internal
Comment 2 Philippe Renon 2017-09-15 13:36:06 UTC 
Created attachment 359849 [details] [review]
introduce helper method to remove seek source

this incidentally fixes a missing g_source_destroy() call in _main()
Comment 3 Sebastian Dröge (slomo) 2017-09-15 14:29:24 UTC 
commit 085f875a249ba73cf24e42c72ba811ab461efa6d (HEAD -> master)
Author: Philippe Renon <philippe_renon@yahoo.fr>
Date:   Fri Sep 15 15:04:02 2017 +0200

    player: introduce helper method to remove seek source
    
    this incidentally fixes a missing g_source_destroy() call in _main()
    
    https://bugzilla.gnome.org/show_bug.cgi?id=787727

commit 9fce29497da5ebee5d333911a94b7c18ab0410bf
Author: Philippe Renon <philippe_renon@yahoo.fr>
Date:   Fri Sep 15 14:58:56 2017 +0200

    player: remove duplicate state_ret check in play internal
    
    https://bugzilla.gnome.org/show_bug.cgi?id=787727