Someone using v4l2radio, that's a surprise, that might impair my plan to make it a bin and wrap alsa/pulse source inside of it .... Do you mind letting us know which hardware has a driver for that ?

Thanks for your patch, I'll have a look.

Review of attachment 359843 [details] [review]:

::: sys/v4l2/gstv4l2radio.c
@@ +62,3 @@
   ARG_DEVICE,
+  ARG_FREQUENCY,
+  ARG_SIGNAL_STRENGTH

That's nice, you added an enum, but it won't show up if you don't call g_object_class_install_property() in the class init. Did you tested your patch ?

@@ +483,3 @@
       }
       break;
+    case ARG_SIGNAL_STRENGTH:

Some GST_OBJECT_LOCK() all over maybe ? Can you really set the signal strenght ? What those it means ?

V4L2 API already offer seeking, don't you want to expose the V4L2 API instead ?

USB and PCI FM tuners are very similar to TV tuners, in fact, many TV tuner cards have an FM tuner built in. Or for testing only: The Virtual Video Test Driver (vivid) https://www.kernel.org/doc/html/v4.12/media/v4l-drivers/vivid.html

No, I not test patch, is made in haste.

PS. Another useful thing would be to use it GstDeviceMonitor to list and monitor v4l2 radio devices.

(In reply to triniton from comment #4)
> PS. Another useful thing would be to use it GstDeviceMonitor to list and
> monitor v4l2 radio devices.

https://bugzilla.gnome.org/show_bug.cgi?id=743108

The reason this was kept low interest is that there is very few real driver for that, the element does not produce audio, a lot of these USB dongle in fact support SDR stream and often are access via libusb/rtl instead of a v4l2 driver.

One should maybe upstream this plugin at some point:

https://github.com/PDXostc/fmradioservice/tree/master/gst-sdr-j-fm

Works with most DVB T receiver that advertise FM support.

A lot of hardware: https://www.google.ro/search?q=pci++tv+fm+tuner&client=browser-ubuntu&hs=aIa&channel=fe&hl=en&dcr=0&source=lnms&tbm=isch&sa=X&ved=0ahUKEwjNtpHJvafWAhWDFJoKHcg4Ce8Q_AUICigB&biw=1272&bih=629.

With upstream kernel drivers ?

So, are you going to update and test your patch ? Untested patches aren't really welcome.

Yes with upstream kernel drivers:
BTTV cards list - https://linuxtv.org/downloads/v4l-dvb-apis/v4l-drivers/bttv-cardlist.html
SAA7134 cards list - https://linuxtv.org/downloads/v4l-dvb-apis/v4l-drivers/saa7134-cardlist.html
CX88 cards list: https://linuxtv.org/downloads/v4l-dvb-apis/v4l-drivers/cx88-cardlist.html

My card is PCI TV Tuner with FM Radio based on SAA7134 and work fine with gst v4l2radio, I also have a lot of friends who have a FM chip build-in TV card.

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/403.