After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787684 - Rename the names of the icons' files
Rename the names of the icons' files
Status: RESOLVED DUPLICATE of bug 787013
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on: 787013
Blocks:
 
 
Reported: 2017-09-14 15:47 UTC by Iñigo Martínez
Modified: 2017-09-18 17:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Rename the names of the icons files (10.00 KB, patch)
2017-09-14 15:48 UTC, Iñigo Martínez 		reviewed Details | Review

Description Iñigo Martínez 2017-09-14 15:47:18 UTC 
The names of icons' files, besides containing the final names, they also contained the path in which they were going to be installed. This implies that they have to be renamed on the installation process.
Comment 1 Iñigo Martínez 2017-09-14 15:48:46 UTC 
Created attachment 359804 [details] [review]
Rename the names of the icons files

This patch creates the proper directory tree needed on the installation process and renames all files' names to their final names.
Comment 2 Bastien Nocera 2017-09-17 11:46:05 UTC 
Any reason this patch isn't in bug 787013 ?
Comment 3 Iñigo Martínez 2017-09-17 14:12:39 UTC 
If I knew that autotools was definitely going to be removed, I would have added it.

A similar issue[0] that also depended on meson, ended up as an autotools patch.

[0] https://bugzilla.gnome.org/show_bug.cgi?id=787105
Comment 4 Bastien Nocera 2017-09-18 14:45:34 UTC 
Review of attachment 359804 [details] [review]:

It's not clear from the patch whether things worked before or not. If things worked, then why do we need this patch. If it didn't work, please merge it in the mega-meson patch in bug 787013.
Comment 5 Cosimo Cecchi 2017-09-18 17:59:32 UTC 
Agreed, since this is on top of the patches in bug 787013, let's merge it with those patches.

*** This bug has been marked as a duplicate of bug 787013 ***