After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787678 - os-database, wizard-source: Use named constants with the GtkListStore with media URLs'
os-database, wizard-source: Use named constants with the GtkListStore with me...
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks: 786679
 
 
Reported: 2017-09-14 14:51 UTC by Debarshi Ray
Modified: 2017-10-12 19:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
os-database, wizard-source: Use named constants, not magic numbers (3.15 KB, patch)
2017-09-14 14:53 UTC, Debarshi Ray 		none Details | Review
os-database, wizard-source: Use named constants (3.16 KB, patch)
2017-09-14 15:35 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2017-09-14 14:51:59 UTC 
So far the GtkListStore had a single column, but commit a63e080ad84b02b4 introduced a second column. It might be nicer to use enumerated constants than integer literals to refer to the columns.
Comment 1 Debarshi Ray 2017-09-14 14:53:02 UTC 
Created attachment 359790 [details] [review]
os-database, wizard-source: Use named constants, not magic numbers
Comment 2 Zeeshan Ali 2017-09-14 14:56:19 UTC 
Review of attachment 359790 [details] [review]:

cool! Nitpick on shortlog: it can easily be made to fit under 50 chars, which is recommended.

"os-db,wizard-source: Use named constants

Instead of magic numbers"
Comment 3 Debarshi Ray 2017-09-14 15:32:04 UTC 
(In reply to Zeeshan Ali (Khattak) from comment #2)
> Review of attachment 359790 [details] [review] [review]:
> 
> cool! Nitpick on shortlog: it can easily be made to fit under 50 chars,
> which is recommended.
> 
> "os-db,wizard-source: Use named constants
> 
> Instead of magic numbers"

That's a good point, sure. I always struggle to come up with a good commit message.
Comment 4 Debarshi Ray 2017-09-14 15:35:44 UTC 
Created attachment 359801 [details] [review]
os-database, wizard-source: Use named constants
Comment 5 Felipe Borges 2017-09-20 13:28:32 UTC 
Review of attachment 359801 [details] [review]:

Yes! Thanks for your patches!