After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787628 - omxvideodec: log info about frame before releasing it
omxvideodec: log info about frame before releasing it
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal normal
: 1.12.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-13 13:35 UTC by Guillaume Desmottes
Modified: 2017-09-14 16:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
omxvideodec: log info about frame before releasing it (2.12 KB, patch)
2017-09-13 13:36 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2017-09-13 13:35:57 UTC 
.
Comment 1 Guillaume Desmottes 2017-09-13 13:36:16 UTC 
Created attachment 359725 [details] [review]
omxvideodec: log info about frame before releasing it

gst_video_decoder_release_frame() takes ownership of the frame and will
destroy it. So we should no longer use it after calling it.
Comment 2 Tim-Philipp Müller 2017-09-14 16:45:08 UTC 
Thanks. Pushed to master and 1.12/1.10 branches.

I have removed the accidental common submodule reverts in your patch before committing.

commit 1bc6976b7b8c11ad9dc47fa5a6333f6bc6cddd81
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Wed Sep 13 15:32:51 2017 +0200

    omxvideodec: log info about frame before releasing it
    
    gst_video_decoder_release_frame() takes ownership of the frame and will
    destroy it. So we should no longer use it after calling it.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=787628