After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787616 - glupload: add crop meta support in dmafd uploader
glupload: add crop meta support in dmafd uploader
Status: RESOLVED INCOMPLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.12.x
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-13 09:04 UTC by Haihua Hu
Modified: 2018-06-06 19:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
glupload: add crop meta support in dmafd uploader (1.78 KB, patch)
2017-09-13 09:06 UTC, Haihua Hu 		needs-work Details | Review

Description Haihua Hu 2017-09-13 09:04:25 UTC 
dmafd upload can import video crop. So need get the input videocrop and update videoinfo
Comment 1 Haihua Hu 2017-09-13 09:06:09 UTC 
Created attachment 359694 [details] [review]
glupload: add crop meta support in dmafd uploader
Comment 2 Nicolas Dufresne (ndufresne) 2017-09-13 14:24:51 UTC 
Review of attachment 359694 [details] [review]:

::: gst-libs/gst/gl/gstglupload.c
@@ +737,3 @@
+  if (crop) {
+    in_info->width = MIN (crop->width, in_info->width);
+    in_info->height = MIN (crop->height, in_info->height);

And what if x,y is non-zero ?
Comment 3 Nicolas Dufresne (ndufresne) 2017-12-19 00:57:15 UTC 
Any reply for this review comment ?
Comment 4 Haihua Hu 2017-12-19 00:59:12 UTC 
(In reply to Nicolas Dufresne (stormer) from comment #3)
> Any reply for this review comment ?

it is a bit little complicated for x,y. Do you have any ideal?
Comment 5 Nicolas Dufresne (ndufresne) 2017-12-19 02:11:09 UTC 
(In reply to Haihua Hu from comment #4)
> (In reply to Nicolas Dufresne (stormer) from comment #3)
> > Any reply for this review comment ?
> 
> it is a bit little complicated for x,y. Do you have any ideal?

Well, GstVideoCropMeta is all about this x,y and the fact it's possibly not aligned with the sub-sampling. Otherwise you can use GstVideoAligment really, the GL pool supports that pretty well.
Comment 6 Nicolas Dufresne (ndufresne) 2017-12-19 02:11:43 UTC 
Review of attachment 359694 [details] [review]:

That's incomplete in regard to what GstVideoCropMeta is.
Comment 7 Nicolas Dufresne (ndufresne) 2018-06-06 19:52:58 UTC 
Closing this bug report as no further information has been provided. Please feel free to reopen this bug report if you can provide the information that was asked for in a previous comment.
Thanks!