After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787613 - vaapi: wrong counting of the array of attributes for vaConfig
vaapi: wrong counting of the array of attributes for vaConfig
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
unspecified
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-13 08:19 UTC by Hyunjun Ko
Modified: 2017-09-13 09:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libs: context: fix wrong counter of the array of attributes (2.96 KB, patch)
2017-09-13 08:20 UTC, Hyunjun Ko 		committed Details | Review

Description Hyunjun Ko 2017-09-13 08:19:23 UTC 
There was wrong logic to count the number of the array of attributes when creating vaConfig.

It was lucky that this hasn't cause a real problem. But I got this warning lately.


0:00:01.352460782 4202 0x5607f5b2e400 WARN vaapi gstvaapicontext.c:356:config_create: Failed to create vaConfig
0:00:01.352503471 4202 0x5607f5b2e400 WARN vaapiencode gstvaapiencode.c:421:ensure_allowed_sinkpad_caps:<vaapiencodeh264-0> failed to get allowed surface formats


This is because the driver reads wrong element of the array of attributes.
Comment 1 Hyunjun Ko 2017-09-13 08:20:13 UTC 
Created attachment 359692 [details] [review]
libs: context: fix wrong counter of the array of attributes

So far, it passes wrong value of counter, which is always +1, to vaCreateConfig.
This fixes wrong counting of the arry of attributes.
Comment 2 Víctor Manuel Jáquez Leal 2017-09-13 08:53:54 UTC 
Ooops! my fault. This is regression caused by commit e42ec3ad3c5dfcc9ae6826b6b215b8d6efd856ab
Comment 3 Víctor Manuel Jáquez Leal 2017-09-13 09:23:49 UTC 
Attachment 359692 [details] pushed as 9875c0d - libs: context: fix wrong counter of the array of attributes