After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787592 - can't access object content and highlight without compositor
can't access object content and highlight without compositor
Status: RESOLVED FIXED
Product: accerciser
Classification: Applications
Component: core
unspecified
Other All
: Normal normal
: ---
Assigned To: Accerciser Developers
Accerciser Developers
Depends on:
Blocks:
 
 
Reported: 2017-09-12 19:28 UTC by Samuel Thibault
Modified: 2019-04-01 15:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix (2.80 KB, text/plain)
2017-09-12 19:28 UTC, Samuel Thibault 		  Details
proposed fix (2.95 KB, patch)
2017-09-12 19:44 UTC, Samuel Thibault 		none Details | Review

Description Samuel Thibault 2017-09-12 19:28:37 UTC 
Created attachment 359656 [details]
proposed fix

Hello,

My desktop doesn't include a compositor.  When I click on an object in
the at-spi tree, I get this in the accerciser output:

Traceback (most recent call last):

+ Trace 237951

  • File "/usr/lib/python3/dist-packages/accerciser/accessible_treeview.py", line 839 in _onSelectionChanged 
    self.node.update(new_acc)
  • File "/usr/lib/python3/dist-packages/accerciser/node.py", line 100 in update 
    self.highlight()
  • File "/usr/lib/python3/dist-packages/accerciser/node.py", line 134 in highlight 
    2.0, 0)
  • File "/usr/lib/python3/dist-packages/accerciser/node.py", line 222 in __init__ 
    self.root = gdk.get_default_root_window().get_image(
AttributeError: 'X11Window' object has no attribute 'get_image' 

and I don't get attributes, content, etc. of the object.

Indeed, get_image is something that got removed between gtk+2.0 and
gtk+3.0, it seems the migration in accerciser didn't fix that part,
probably because the maintainer does use a compositor.

Basically, everything used here was removed in gtk+3.0, and cairo
is supposed to be used instead. But « Cairo will always use
GDK_INCLUDE_INFERIORS on sources and masks and GDK_CLIP_BY_CHILDREN on
targets. » So basically we can't use gtk/gdk to achieve highlighting.
In the attached patch, I just use an X11 implementation. Of course it
won't work under Wayland, but AIUI Wayland will always have a
compositor, so that's not a problem.

Samuel
Comment 1 Samuel Thibault 2017-09-12 19:44:21 UTC 
Created attachment 359662 [details] [review]
proposed fix

Of course, the last-minute change I made before submitting did break my
patch :) Here is  the fixed version.
Comment 2 Samuel Thibault 2019-03-19 15:24:00 UTC 
Ping? This issue is making accerciser way less usable since one does not get a quick feedback as to what is being inspected.
Comment 3 Alex ARNAUD 2019-03-19 15:27:36 UTC 
(In reply to Samuel Thibault from comment #2)
> Ping? This issue is making accerciser way less usable since one does not get
> a quick feedback as to what is being inspected.

I assume that Javier no longer reviews patches so if your patch is reasonable you should merge it yourself.

Best regards,
Alex.
Comment 4 Samuel Thibault 2019-04-01 15:28:33 UTC 
This was commited as 1da6d1bcb1ffd8b7e330e93c9a77ac690f0caba3