After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787590 - Replace use of gnome_desktop_thumbnail_scale_down_pixbuf()
Replace use of gnome_desktop_thumbnail_scale_down_pixbuf()
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
3.26.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
: 787591 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-09-12 15:41 UTC by Emmanuele Bassi (:ebassi)
Modified: 2017-09-13 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Replace gnome-desktop utility function (1.38 KB, patch)
2017-09-12 15:42 UTC, Emmanuele Bassi (:ebassi) 		reviewed Details | Review

Description Emmanuele Bassi (:ebassi) 2017-09-12 15:41:30 UTC 
Evolution's build is failing in Continuous because of an API change in libgnome-desktop:

https://git.gnome.org/browse/gnome-desktop/commit/?id=2887d752290762d81b23159143fcdcbbf0e90600

The replacement is pretty trivial.
Comment 1 Emmanuele Bassi (:ebassi) 2017-09-12 15:42:58 UTC 
Created attachment 359643 [details] [review]
Replace gnome-desktop utility function

The gnome_desktop_thumbnail_scale_down_pixbuf() utility function has
been removed in gnome-desktop 3.27, and it wasn't much of a utility
anyway, as it can be simply replaced with a single call to GdkPixbuf's
own scaling API with exactly the same parameters and results.

This allows us to remove a conditional build branch, and simplifies the
code.
Comment 2 Piotr Drąg 2017-09-12 17:16:02 UTC 
*** Bug 787591 has been marked as a duplicate of this bug. ***
Comment 3 Milan Crha 2017-09-13 16:15:19 UTC 
Thanks for a bug report and patch. It's really trivial, I only fixed spaces versus tabs coding style issue. As it's a no-harm change I'm committing it to the stable branch as well.

Created commit ec5de77564 in evo master (3.27.1+)
Created commit f4caa0c55f in evo gnome-3-26 (3.26.1+)