After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787513 - language-chooser: normalize, unaccent and casefold compared strings
language-chooser: normalize, unaccent and casefold compared strings
Status: RESOLVED FIXED
Product: gnome-initial-setup
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Initial Setup maintainer(s)
GNOME Initial Setup maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-09-10 17:09 UTC by Cosimo Cecchi
Modified: 2017-10-26 08:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
language-chooser: normalize, unaccent and casefold compared strings (4.50 KB, patch)
2017-09-10 17:09 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2017-09-10 17:09:57 UTC 
Right now we're shipping an unused copy of this code; instead, use it for a better sorting in the language chooser.
Comment 1 Cosimo Cecchi 2017-09-10 17:09:59 UTC 
Created attachment 359472 [details] [review]
language-chooser: normalize, unaccent and casefold compared strings

To further improve the sorting of the language chooser, lower cased,
accented and non-casefolded strings should be compared equally.

This patch makes the sorting function insensitive to these factors.

The code to do this already exists, unused, in the keyboard page,
so it has been moved to the language page.
Comment 2 Rui Matos 2017-10-25 15:39:28 UTC 
Review of attachment 359472 [details] [review]:

lgtm
Comment 3 Cosimo Cecchi 2017-10-26 08:01:37 UTC 
Attachment 359472 [details] pushed as 6e83cf8 - language-chooser: normalize, unaccent and casefold compared strings

Thanks, pushed.