After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787436 - Commit 0815e5e89 breaks baobab
Commit 0815e5e89 breaks baobab
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Code Generator
0.37.x
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-08 10:28 UTC by Stefano Facchini
Modified: 2017-09-09 08:33 UTC
See Also:
GNOME target: 3.26
GNOME version: ---

Attachments
codegen: Try to use a more unique internal define for properties (3.24 KB, patch)
2017-09-08 12:47 UTC, Rico Tzschichholz 		committed Details | Review

Description Stefano Facchini 2017-09-08 10:28:06 UTC 
See baobab's bug 787419.

Reverting the single commit 0815e5e89 (codegen: Use g_object_notify_by_pspec() to notify property-changes) on top of master solves it.


As additional information, in the baobab Makefile we currently have:

VALA_SOURCES = \
        baobab-application.vala         \
        baobab-cellrenderers.vala       \
        baobab-chart.vala               \
        baobab-treemap.vala             \
        baobab-ringschart.vala          \
        baobab-location.vala            \
        baobab-location-list.vala       \
        baobab-scanner.vala             \
        baobab-window.vala              \
        main.vala                       \
        $(NULL)


Reordering it as follows:

VALA_SOURCES = \
        baobab-application.vala         \
        baobab-cellrenderers.vala       \
        baobab-chart.vala               \
        baobab-location-list.vala       \
        baobab-location.vala            \
        baobab-treemap.vala             \
        baobab-ringschart.vala          \
        baobab-scanner.vala             \
        baobab-window.vala              \
        main.vala                       \
        $(NULL)

also makes it work again.
Comment 1 Rico Tzschichholz 2017-09-08 12:47:21 UTC 
Created attachment 359398 [details] [review]
codegen: Try to use a more unique internal define for properties
Comment 2 Rico Tzschichholz 2017-09-08 12:57:41 UTC 
Note this is not really a new issue, but one which finally triggered a fatal problem.

Baobab.Chart.MAX_DEPTH re-defined the internal enum-value BAOBAB_CHART_MAX_DEPTH and array-bound warnings by gcc showed the issue.
Comment 3 Rico Tzschichholz 2017-09-08 15:31:04 UTC 
Attachment 359398 [details] pushed as 8bd7fbc - codegen: Try to use a more unique internal define for properties
Comment 4 Al Thomas 2017-09-09 07:55:30 UTC 
8bd7fbc hasn't fixed the issue with Baobab - see https://bugzilla.gnome.org/show_bug.cgi?id=787419#c2
Comment 5 Al Thomas 2017-09-09 08:33:05 UTC 
Not a problem with the Vala fix, reporter has solved problem their end: https://bugzilla.gnome.org/show_bug.cgi?id=787419#c6