After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787430 - qmlglsink build fails on Windows in QtCreator
qmlglsink build fails on Windows in QtCreator
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.12.x
Other Windows
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-08 08:21 UTC by holger.weber
Modified: 2018-08-30 11:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
qmlglsink patch for windows (3.30 KB, patch)
2017-09-08 08:21 UTC, holger.weber 		none Details | Review
patch for master (2.40 KB, patch)
2017-09-11 12:24 UTC, holger.weber 		reviewed Details | Review

Description holger.weber 2017-09-08 08:21:32 UTC 
Created attachment 359389 [details] [review]
qmlglsink patch for windows

Building the qmlglsink element under windows with QtCreator fails because of several issues.

Patch to fix it is attached but only works for the sink element.
Comment 1 Sebastian Dröge (slomo) 2017-09-11 09:35:55 UTC 
Comment on attachment 359389 [details] [review]
qmlglsink patch for windows

The patch does not apply to latest GIT master, and GIT doesn't like it because of the broken author field either.
Comment 2 holger.weber 2017-09-11 12:24:38 UTC 
Created attachment 359523 [details] [review]
patch for master

I hope this patch works.
Comment 3 Sebastian Dröge (slomo) 2017-09-13 13:34:48 UTC 
Review of attachment 359523 [details] [review]:

::: ext/qt/gstplugin.cc
@@ +35,3 @@
   }
   
+#ifndef HAVE_QT_WIN32

Is there any particular difficulty with porting the src?

::: ext/qt/gstqtglutility.cc
@@ +240,3 @@
       gst_object_unref (window);
       if (!gst_gl_context_create (*context, *wrap_glcontext, &error)) {
+        GST_ERROR ("failed to create shared GL context: %s", error->message);

Why can't "this" not be printed with %p?
Comment 4 holger.weber 2017-09-13 13:40:06 UTC 
There was no reference to "this", so I changed the parameters like in line 202.
Comment 5 Sebastian Dröge (slomo) 2017-09-14 07:08:42 UTC 
Indeed. What about the difficulty to port the source? It seems like there is nothing platform specific at all in there?
Comment 6 Matthew Waters (ystreet00) 2018-08-30 11:08:25 UTC 
I believe this has been fixed in various stages over the last year.