After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787414 - meson: Rework gir/typelib generation and dependencies
meson: Rework gir/typelib generation and dependencies
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2017-09-07 18:19 UTC by Nirbheek Chauhan
Modified: 2017-09-11 17:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
meson: Rework gir/typelib generation and dependencies (8.65 KB, patch)
2017-09-07 18:19 UTC, Nirbheek Chauhan 		committed Details | Review

Description Nirbheek Chauhan 2017-09-07 18:19:19 UTC 
GIR generation fails for me without these changes, and the dependency changes are needed for using pango as a subproject inside gtk+

FAILED: subprojects/pango/pango/PangoXft-1.0.gir 
/usr/bin/g-ir-scanner [...] --include-uninstalled=pango/Pango-1.0.gir --include-uninstalled=pango/PangoFT2-1.0.gir [...]
Traceback (most recent call last):

+ Trace 237937

  • File "/usr/bin/g-ir-scanner", line 66 in <module> 
    sys.exit(scanner_main(sys.argv))
  • File "/usr/lib64/gobject-introspection/giscanner/scannermain.py", line 529 in scanner_main 
    transformer = create_transformer(namespace, options)
  • File "/usr/lib64/gobject-introspection/giscanner/scannermain.py", line 401 in create_transformer 
    transformer.register_include_uninstalled(include_path)
  • File "/usr/lib64/gobject-introspection/giscanner/transformer.py", line 153 in register_include_uninstalled 
    self._parse_include(include_path, uninstalled=True)
  • File "/usr/lib64/gobject-introspection/giscanner/transformer.py", line 221 in _parse_include 
    parser = self._cachestore.load(filename)
  • File "/usr/lib64/gobject-introspection/giscanner/cachestore.py", line 183 in load 
    if not self._cache_is_valid(store_filename, filename):
  • File "/usr/lib64/gobject-introspection/giscanner/cachestore.py", line 119 in _cache_is_valid 
    os.stat(filename).st_mtime)
OSError: [Errno 2] No such file or directory: 'pango/Pango-1.0.gir' 






Comment 1


Nirbheek Chauhan





          2017-09-07 18:19:23 UTC
        



Created attachment 359371 [details] [review]
meson: Rework gir/typelib generation and dependencies

Don't use --include-uninstalled, it's not needed with Meson because we
take care of inter-gir target dependencies.

Add girs and typelibs to the relevant libpango*_dep declared
dependencies so that they can be used via subprojects.






Comment 2


Emmanuele Bassi (:ebassi)





          2017-09-11 17:26:31 UTC
        



Review of attachment 359371 [details] [review]:

Looks like a nice cleanup indeed.






Comment 3


Nirbheek Chauhan





          2017-09-11 17:39:04 UTC
        



Thanks, pushed!

Attachment 359371 [details] pushed as 711af0c - meson: Rework gir/typelib generation and dependencies