After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787412 - Make sure that sync happens only in BROWSER mode
Make sure that sync happens only in BROWSER mode
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Sync
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-07 15:40 UTC by Gabriel Ivașcu
Modified: 2017-09-08 13:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make sure that sync happens only in BROWSER mode (6.26 KB, patch)
2017-09-07 15:41 UTC, Gabriel Ivașcu 		none Details | Review
Make sure that sync happens only in BROWSER mode (6.13 KB, patch)
2017-09-07 16:27 UTC, Gabriel Ivașcu 		committed Details | Review

Description Gabriel Ivașcu 2017-09-07 15:40:35 UTC 
At the moment, EphySyncService is created when mode != APPLICATION and mode != INCOGNITO. This doesn't include the other modes when we don't want to sync anything, such as STANDALONE (user runs Epiphany with a profile directory different than the default one) or PRIVATE (user runs Epiphany with a temporary profile directory).
Comment 1 Gabriel Ivașcu 2017-09-07 15:41:43 UTC 
Created attachment 359363 [details] [review]
Make sure that sync happens only in BROWSER mode
Comment 2 Michael Catanzaro 2017-09-07 15:44:47 UTC 
Review of attachment 359363 [details] [review]:

LGTM
Comment 3 Michael Catanzaro 2017-09-07 16:23:26 UTC 
Review of attachment 359363 [details] [review]:

::: src/ephy-shell.c
@@ +417,3 @@
 
+      if (mode == EPHY_EMBED_SHELL_MODE_BROWSER) {
+        if (ephy_sync_utils_user_is_signed_in ()) {

Nit: this should be done in one conditional, so you don't need the extra level of indentation.
Comment 4 Gabriel Ivașcu 2017-09-07 16:27:56 UTC 
Created attachment 359366 [details] [review]
Make sure that sync happens only in BROWSER mode

OK, combined the two conditionals into one.
Comment 5 Gabriel Ivașcu 2017-09-08 13:51:08 UTC 
Attachment 359366 [details] pushed as 5afbcfd - Make sure that sync happens only in BROWSER mode

Release team approved a freeze break for this.