After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787367 - parsebin: Emit 'drained' only for the top-level chain
parsebin: Emit 'drained' only for the top-level chain
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-06 14:53 UTC by Edward Hervey
Modified: 2017-11-10 09:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
parsebin: Emit 'drained' only for the top-level chain (2.40 KB, patch)
2017-09-06 14:53 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2017-09-06 14:53:19 UTC 
See patch
Comment 1 Edward Hervey 2017-09-06 14:53:23 UTC 
Created attachment 359276 [details] [review]
parsebin: Emit 'drained' only for the top-level chain

Instead of emitting 'drained' whenever every single chain is drained
(which would result in plenty of signal emission, and would also
occur when switching groups), only emit it when the top-level chain
is drained.

Furthermore, mark unknown (and therefore unexposed) pads as drained
since we'll never get EOS on them.
Comment 2 Edward Hervey 2017-11-10 09:06:12 UTC 
Comment on attachment 359276 [details] [review]
parsebin: Emit 'drained' only for the top-level chain

commit 92e88768443a21eab5d2dd6bc7a318c9b46e54f8 (HEAD -> master, origin/master, origin/HEAD)
Author: Edward Hervey <edward@centricular.com>
Date:   Wed Sep 6 16:50:31 2017 +0200

    parsebin: Emit 'drained' only for the top-level chain
    
    Instead of emitting 'drained' whenever every single chain is drained
    (which would result in plenty of signal emission, and would also
    occur when switching groups), only emit it when the top-level chain
    is drained.
    
    Furthermore, mark unknown (and therefore unexposed) pads as drained
    since we'll never get EOS on them.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=787367