After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787357 - Port StorageView to Gtk+ composite templates
Port StorageView to Gtk+ composite templates
Status: RESOLVED FIXED
Product: gnome-usage
Classification: Other
Component: storage
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Usage maintainer(s)
GNOME Usage maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-09-06 11:57 UTC by Felipe Borges
Modified: 2017-09-11 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
storage-view: Port to Gtk+ composite templates (8.38 KB, patch)
2017-09-06 11:57 UTC, Felipe Borges 		committed Details | Review

Description Felipe Borges 2017-09-06 11:57:08 UTC 
.
Comment 1 Felipe Borges 2017-09-06 11:57:32 UTC 
Created attachment 359259 [details] [review]
storage-view: Port to Gtk+ composite templates

It simplifies the StorageView code a lot by decoupling the Gtk+
specific bits.

In terms of logic, we now switch stack pages to present the
"loading", "content", and "empty" states. This is simpler than
the addition and removal of widgets on callbacks.
Comment 2 Petr Štětka 2017-09-11 13:10:08 UTC 
Review of attachment 359259 [details] [review]:

Thanks for patch, Felipe!

Accepted.
Comment 3 Felipe Borges 2017-09-11 13:40:36 UTC 
Attachment 359259 [details] pushed as a7a8ae9 - storage-view: Port to Gtk+ composite templates