After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787347 - Respect OnlyShowIn in desktop files
Respect OnlyShowIn in desktop files
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Sharing
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-06 08:10 UTC by Didier Roche
Modified: 2017-09-12 13:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Only load panels corresponding to OnlyShowIn/NotShowIn (1.21 KB, patch)
2017-09-06 08:10 UTC, Didier Roche
committed Details | Review

Description Didier Roche 2017-09-06 08:10:37 UTC
Created attachment 359253 [details] [review]
Only load panels corresponding to OnlyShowIn/NotShowIn

Only load panel corresponding to OnlyShowIn/NotShowIn

Most panel desktop files have an OnlyShowIn entry to display them
in the previous iconish G-C-C UI. Some distributions (like ubuntu) prefers
adding new panel rather than patching the existing ones to ensure that
the upstream Control Center look it preserved under a vanilla GNOME session.
This patch fix thus the new layout setting to respect the OnlyShowIn property.

(Note that this a regression compared to 2.24).

Tell me if the patch attached works for you!
Comment 1 Rui Matos 2017-09-12 12:48:49 UTC
Review of attachment 359253 [details] [review]:

lgtm, please push to master and gnome-3-26
Comment 2 Didier Roche 2017-09-12 13:21:53 UTC
Thank for the review!

I don't have commit rights though (will need to get that fixed ;)), do you mind pushing it?
Comment 3 Felipe Borges 2017-09-12 13:33:37 UTC
Attachment 359253 [details] pushed as 3e04b1c - Only load panel corresponding to OnlyShowIn/NotShowIn
Comment 4 Didier Roche 2017-09-12 13:34:43 UTC
Thanks Felipe & Rui :)
Comment 5 Felipe Borges 2017-09-12 13:35:40 UTC
for gnome-3-26

Attachment 359253 [details] pushed as 43dbc70 - Only load panel corresponding to OnlyShowIn/NotShowIn