After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787336 - template-glib: Don't store build dir in generated files
template-glib: Don't store build dir in generated files
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
3.25.x
Other All
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-06 01:12 UTC by Jeremy Bicha
Modified: 2017-09-06 01:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't store build dir in generated files (1.05 KB, patch)
2017-09-06 01:12 UTC, Jeremy Bicha 		committed Details | Review

Description Jeremy Bicha 2017-09-06 01:12:18 UTC 
Before this patch, there are comments like this in /usr/include/template-glib-1.0/tmpl-enums.h :

/* enumerations from "/build/template-glib-jwsHSz/template-glib-3.25.3/obj-x86_64-linux-gnu/../src/tmpl-error.h" */

After, it becomes:

/* enumerations from "tmpl-error.h" */

This is inspired by Debian's Reproducible Builds project and this similar recent pango commit:

https://git.gnome.org/browse/pango/commit/?id=9e16ddd4
Comment 1 Jeremy Bicha 2017-09-06 01:12:21 UTC 
Created attachment 359246 [details] [review]
Don't store build dir in generated files
Comment 2 Christian Hergert 2017-09-06 01:55:35 UTC 
Review of attachment 359246 [details] [review]:

LGTM
Comment 3 Christian Hergert 2017-09-06 01:56:12 UTC 
Attachment 359246 [details] pushed as e3f021e - Don't store build dir in generated files