After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787316 - Release 3.18.12
Release 3.18.12
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
3.18.x (obsolete)
Other Linux
: Normal enhancement
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-05 15:41 UTC by Amr Ibrahim
Modified: 2017-09-05 20:44 UTC
See Also:
GNOME target: ---
GNOME version: 3.17/3.18


Attachments
Fix EphyHistoryService (879 bytes, patch)
2017-09-05 17:17 UTC, Michael Catanzaro
committed Details | Review

Description Amr Ibrahim 2017-09-05 15:41:45 UTC
Is there a plan to release 3.18.12 containing the fixes after 3.18.11 was released?
It is easier for distributors to push micro-releases updates than cherry-picking single commits.
Comment 1 Amr Ibrahim 2017-09-05 15:43:15 UTC
I am talking about stable and long-term support distributions in particular.
Comment 2 Michael Catanzaro 2017-09-05 17:03:14 UTC
Unfortunately that branch is broken right now, there's a crash on startup in the history service:

(gdb) bt
  • #0 ephy_history_service_set_property
    at /home/mcatanzaro/Projects/GNOME/epiphany/lib/history/ephy-history-service.c line 97
  • #1 object_set_property
    at /home/mcatanzaro/Projects/GNOME/glib/gobject/gobject.c line 1423
  • #2 g_object_new_internal
    at /home/mcatanzaro/Projects/GNOME/glib/gobject/gobject.c line 1815
  • #3 g_object_new_valist
    at /home/mcatanzaro/Projects/GNOME/glib/gobject/gobject.c line 2104
  • #4 g_object_new
    at /home/mcatanzaro/Projects/GNOME/glib/gobject/gobject.c line 1624
  • #5 ephy_history_service_new
    at /home/mcatanzaro/Projects/GNOME/epiphany/lib/history/ephy-history-service.c line 329

Problem is that self->priv is NULL. Not sure why priv is not being initialized. That's bad.
Comment 3 Michael Catanzaro 2017-09-05 17:12:58 UTC
I bisected it to "history-service: Fix multiple initialization race conditions" so maybe something went wrong when I backported that patch.
Comment 4 Michael Catanzaro 2017-09-05 17:17:02 UTC
The following fix has been pushed:
9114b58 Fix EphyHistoryService
Comment 5 Michael Catanzaro 2017-09-05 17:17:05 UTC
Created attachment 359220 [details] [review]
Fix EphyHistoryService

Accidentally deleted initialization of priv when backporting
aaf8763d6615185faebde926ce7084437489f344
Comment 6 Michael Catanzaro 2017-09-05 20:12:18 UTC
OK, released: https://mail.gnome.org/archives/ftp-release-list/2017-September/msg00059.html. Thanks for the reminder; it was time for a new one.

Note that I'm not likely to do another LTS series after 3.18. Instead the plan for the next couple years is to freeze Epiphany's dependencies at what is available in Ubuntu 18.04, that way elementary OS can upgrade to newer major versions instead of being stuck on an LTS release forever. I'm still maintaining 3.18 mainly for elementary at this point. I'm convinced that's where most of our users are.
Comment 7 Amr Ibrahim 2017-09-05 20:44:57 UTC
Thanks Michael.