After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787314 - API docs updates
API docs updates
Status: RESOLVED FIXED
Product: libgudev
Classification: Other
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: libgudev Maintainers
libgudev Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-05 15:17 UTC by Bastien Nocera
Modified: 2017-09-07 11:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gudev: Update list of possible actions (1.05 KB, patch)
2017-09-05 15:17 UTC, Bastien Nocera
committed Details | Review
gudev: Add note about props/attrs when action is "remove" (1.01 KB, patch)
2017-09-05 15:17 UTC, Bastien Nocera
committed Details | Review
gudev: Add note about possible actions (984 bytes, patch)
2017-09-07 11:48 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2017-09-05 15:17:27 UTC
.
Comment 1 Bastien Nocera 2017-09-05 15:17:44 UTC
Created attachment 359198 [details] [review]
gudev: Update list of possible actions

Add "online" and "offline" actions as per:
src/libsystemd/sd-device/device-private.c
in the systemd repository
Comment 2 Bastien Nocera 2017-09-05 15:17:49 UTC
Created attachment 359199 [details] [review]
gudev: Add note about props/attrs when action is "remove"

This takes the guesswork out of it.
Comment 3 Bastien Nocera 2017-09-05 15:19:48 UTC
David, can you review those 2 please?
Comment 4 David Herrmann 2017-09-07 08:26:19 UTC
Review of attachment 359198 [details] [review]:

Note that *any* kernel driver can just add its own actions. So this list is in no way definitive. On the other hand, there is little reason for anyone to ever listen to something other than "add", "change, and "remove", so I am fine with this.
Comment 5 David Herrmann 2017-09-07 08:26:44 UTC
Review of attachment 359199 [details] [review]:

Looks good!
Comment 6 Bastien Nocera 2017-09-07 11:48:21 UTC
Created attachment 359341 [details] [review]
gudev: Add note about possible actions
Comment 7 Bastien Nocera 2017-09-07 11:49:00 UTC
Attachment 359198 [details] pushed as fddb415 - gudev: Update list of possible actions
Attachment 359199 [details] pushed as 93d034d - gudev: Add note about props/attrs when action is "remove"
Attachment 359341 [details] pushed as 39c2829 - gudev: Add note about possible actions