After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787291 - places-menu: GNOME Shell 3.25 complains that PlacesManager is defined using 'const'
places-menu: GNOME Shell 3.25 complains that PlacesManager is defined using '...
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
3.25.x
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-09-05 04:29 UTC by Alexander Rüedlinger (lexruee)
Modified: 2017-09-17 21:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Logfile capturing the JS warning from the GNOME Shell (1.92 KB, text/x-log)
2017-09-05 04:29 UTC, Alexander Rüedlinger (lexruee)
  Details
Patch file that fixs the JS warning in placeDisplay.js (1.12 KB, patch)
2017-09-05 04:34 UTC, Alexander Rüedlinger (lexruee)
committed Details | Review

Description Alexander Rüedlinger (lexruee) 2017-09-05 04:29:59 UTC
Created attachment 359155 [details]
Logfile capturing the JS warning from the GNOME Shell

I just tested GNOME Shell 3.25 on Ubuntu 17.10 and discovered a JS warning.

In short, the GNOME Shell complains that the class PlacesManager in the file placesDisplay.js should not be defined using 'let' or 'const'. For more details see the logfile.
Comment 1 Alexander Rüedlinger (lexruee) 2017-09-05 04:34:59 UTC
Created attachment 359156 [details] [review]
Patch file that fixs the JS warning in placeDisplay.js

This patch file fixes the JS warning in placeDisplay.js.
Comment 2 Florian Müllner 2017-09-05 12:53:56 UTC
Review of attachment 359156 [details] [review]:

Missing line-break in the commit message, otherwise LGTM
Comment 3 Florian Müllner 2017-09-17 21:20:34 UTC
We are no longer in hard code freeze, so pushing.