After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787289 - Glib critical error when creating a new note
Glib critical error when creating a new note
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: general
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-09-05 02:27 UTC by Isaque Galdino
Modified: 2017-09-05 02:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
note-obj: Critical error when creating a new note (1.11 KB, patch)
2017-09-05 02:34 UTC, Isaque Galdino 		committed Details | Review

Description Isaque Galdino 2017-09-05 02:27:26 UTC 
I've noticed an annoying message when creating a new note:
(bijiben:21645): GLib-CRITICAL **: g_strstr_len: assertion 'haystack != NULL' failed
Comment 1 Jonathan Kang 2017-09-05 02:33:23 UTC 
I found this issue a few days ago and created a patch for this issue. I'll attach
the patch later.
Comment 2 Isaque Galdino 2017-09-05 02:34:13 UTC 
Created attachment 359153 [details] [review]
note-obj: Critical error when creating a new note

When creating a new note, Bijiben is thrown a message: "Glib critical
error when creating a new note".

That happens because when it's checking for old notes, it's also trying
to convert new notes, which are null at the start of the process.

This patches checks that and avoids that behaviour.
Comment 3 Isaque Galdino 2017-09-05 02:36:30 UTC 
Review of attachment 359153 [details] [review]:

Pushed to master.
Comment 4 Isaque Galdino 2017-09-05 02:37:23 UTC 
(In reply to Jonathan Kang from comment #1)
> I found this issue a few days ago and created a patch for this issue. I'll
> attach
> the patch later.

Oh, I'm sorry Jonathan, I created the bug just to attach this commit.