After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787279 - EmojiChooser: Hovered emoji become impossible to see in HighContrast/Inverse
EmojiChooser: Hovered emoji become impossible to see in HighContrast/Inverse
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
3.22.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-09-04 23:44 UTC by Daniel Boles
Modified: 2017-09-05 00:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot of hovered emoji in HighContrast (16.60 KB, image/png)
2017-09-04 23:44 UTC, Daniel Boles
  Details
screenshot of hovered emoji in HighContrastInverse (16.47 KB, image/png)
2017-09-04 23:44 UTC, Daniel Boles
  Details
themes: Use $selected_fg_color for :hovered emoji (3.50 KB, patch)
2017-09-04 23:49 UTC, Daniel Boles
none Details | Review

Description Daniel Boles 2017-09-04 23:44:05 UTC
Created attachment 359135 [details]
screenshot of hovered emoji in HighContrast

We're giving them the $selected_bg_color, but leaving the fg colour as-is, which is disastrous in the HighContrast themes: in the light variant, any non-hicolour emoji completely disappears, and in HighContrastInverse it's only barely visible.

It seems worth noting that Adwaita may suffer from this too, for colour emoji whose colours don't coincide nicely with the $selected_bg_color.

The obvious fix is just to set color: $selected_fg_color, which will fix HC and bring both themes in sync with how e.g. hovered menu items look. Hopefully this can't break anything else somehow.
Comment 1 Daniel Boles 2017-09-04 23:44:28 UTC
Created attachment 359136 [details]
screenshot of hovered emoji in HighContrastInverse
Comment 2 Daniel Boles 2017-09-04 23:49:17 UTC
Created attachment 359137 [details] [review]
themes: Use $selected_fg_color for :hovered emoji

This is much needed for HighContrast as otherwise emoji are invisible
(or nearly in Inverse). It also syncs up with hovered menu items, etc.
Comment 3 Daniel Boles 2017-09-05 00:47:12 UTC
Ultimately fixed by https://git.gnome.org/browse/gtk+/commit/?id=9699a954cdb3dd89cba3b1b93f059df76866f790

In the case of 3.22, that took a detour through applying the same change to Adwaita, before deciding that probably isn't a good idea: my system seems highly resistant to showing me any colour emoji, and the closest I've gotten so far are some odd greyscale ones, which show probably unwanted changes in some colours with the CSS fg color property. So, let's not bother with that: only HC has a clear problem here, and users of that will just be glad to see emoji at all.

We could maybe leave the fg colour alone in HC and just ease off the intensity of the bg... but I best leave that to the designers! At least emoji are visible now.