After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787275 - Tab and arrow keys do not work for widget navigation
Tab and arrow keys do not work for widget navigation
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
Flatpak Nightly Channel
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-04 23:04 UTC by Frank
Modified: 2017-09-12 23:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
shortcuts: fix tab/shifttab to change focus (2.37 KB, patch)
2017-09-07 21:26 UTC, Christian Hergert
committed Details | Review

Description Frank 2017-09-04 23:04:51 UTC
Would be cool if documents could be switched by usage of the arrow or tab keys, etc.!
Comment 1 Christian Hergert 2017-09-04 23:42:06 UTC
This seems to be a more generic issue in that our move to libdazzle for shortcut management seems to have broken keyboard navigation with tab/arrows.
Comment 2 Peter E 2017-09-07 08:28:37 UTC
As it's probably related:
Navigating within the project tree with arrow keys is currently only possible when clicking on a folder, not when clicking on a file.
Comment 3 Christian Hergert 2017-09-07 21:25:53 UTC
(In reply to Peter E from comment #2)
> As it's probably related:
> Navigating within the project tree with arrow keys is currently only
> possible when clicking on a folder, not when clicking on a file.

I think that is a different issue, in that we've moved to single-click activation in the treeview for our new designs.

I know changing behavior of base GtkWidgets like this can be controversial, so If someone wants to put in the effort, I'd consider a gsetting to change it + preference switch.
Comment 4 Christian Hergert 2017-09-07 21:26:18 UTC
Created attachment 359376 [details] [review]
shortcuts: fix tab/shifttab to change focus

Since handling our own fallback delivery of events, we lose some of the
default handling by gtkwindow. This allows the toplevel to activate a
signal before we move on to processing application keybindings.
Comment 5 Peter E 2017-09-07 22:51:31 UTC
> in that we've moved to single-click 

Okay, my fault, didn't test this enough. The files I tried already were open.
This inconsistency in navigating is okay I guess. However when done quickly, one can still navigate with the keys while clicking, especially when holding down the mouse. Even opening a file with Enter is possible.

Also the delete key binding for files no longer works, but this might be unrelated (maybe https://bugzilla.gnome.org/show_bug.cgi?id=780472) as renaming with F2 still works.
Comment 6 Christian Hergert 2017-09-08 00:25:27 UTC
(In reply to Peter E from comment #5)
> Also the delete key binding for files no longer works, but this might be
> unrelated (maybe https://bugzilla.gnome.org/show_bug.cgi?id=780472) as
> renaming with F2 still works.

That seems possible. If you run Builder Nightly like this you should see the error in question displayed (and it's probably related to Trash being on another file system).

flatpak run org.gnome.Builder//master -vvvv
Comment 7 Christian Hergert 2017-09-12 23:28:33 UTC
It looks like the underlying issue for this bug was fixed, and we have another bug for the Delete issue so I think it's safe to close this.