After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787269 - Feature request: support right-to-left text in dual mode
Feature request: support right-to-left text in dual mode
Status: RESOLVED OBSOLETE
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-04 21:46 UTC by tomonacci
Modified: 2018-05-22 17:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add right to left mode in dual mode (21.23 KB, patch)
2017-09-04 21:47 UTC, tomonacci
none Details | Review

Description tomonacci 2017-09-04 21:46:25 UTC
Some languages are written from right to left and in those languages pages also go from right to left. It would be nice if Evince supported an option to use right-to-left text/page direction in dual mode. Attached patch adds this option ("Rtl Text") right below the "Odd Pages First" option.

Some notes on the patch:
  * There might be a better name than "Rtl Text" for this option.
  * I am not sure if I did the right thing regarding the cache (EvHeightToPageCache).
  * I did not touch the browser plugin part of the code, but maybe this part also needs modifications if this feature is to be shipped?
  * Perhaps Left and Right keys should be remapped in rtl mode -- Left to "next page" and Right to "previous page". But in that case, rtl mode should not be a sub-mode of dual mode as this inversion of key mapping will be expected when viewing rtl texts in single page mode as well.
Comment 1 tomonacci 2017-09-04 21:47:38 UTC
Created attachment 359109 [details] [review]
Add right to left mode in dual mode
Comment 2 GNOME Infrastructure Team 2018-05-22 17:21:59 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/evince/issues/830.