GNOME Bugzilla – Bug 787232
LUKS password dialogs should be similar to other password dialogs in GNOME
Last modified: 2018-05-24 10:41:45 UTC
This relates to the password changing dialog and the format dialog where it is set. (Btw there could be more than one LUKS password but UDisks can't manage them, only replace a given old one with a new one.)
I can take this on if you like. Did you not update this as part of your format dialog changes?
Hi, the general design is quite similar to the user preferences dialog (control center), but the logic is a bit different and was not touched. The dialog for changing the LUKS password is totally different to the user preferences dialog. Both could maybe use the code (which I did not read rightnow) and widgets from the user preferences. For the "Set Password" dialog this would exchange the password strength widget, add the dynamic sentences and the check icons. The existing password does not apply there of course. The dialog reacts to changes with a timeout. (I'm not sure if weak passwords should be forbidden as well, I personally don't like this approach.) I am happy to test patches and can answer questions via mail. Kai
Hi again, it's been a while but I have resumed work on this. I just have a couple of quick questions. Disks currently displays tooltip messages when hovering over the passphrase entry boxes, but the control center password dialog does not. Is it better to remove these messages for consistency or leave them included for clarity? Similarly, the control center does not have a button to display the passphrases in plain text but Disks currently does. Should we leave this option in or remove it? Personally I feel it isn't necessary to keep it but perhaps some users would prefer to have the option. Thanks.
Users panel used to have tooltips, but designers explicitly wanted their removal, similarly with the button to display the passphrase. So I would suggest doing it the same way... or discuss it on #gnome-design. It would be best to write some generic password widget and share it among all places...
Do you have an opinion on allowing weak passwords? The format dialog already requires a label (which is meaningful but might be annoying to some people!?) and thus it would be consistent to also enforce a good password… That would be the case if the same widget is used (depending on where this is enforced)?
If I am not mistaken GNOME is not consistent in this currently, gnome-initial-setup doesn't enforce strong passwords, but gnome-control-center does (both uses more or less the same dialog). An effort existed to unify the behavior... and allow weak passwords, because it is difficult to choose password with libpwquality, but it is not possible currently for Users panel, because passwd is used directly for logged in users and passwd uses also libpwquality over PAM at least in some distros (e.g. Fedora). So I think it is ok to allow weak passwords here... and the potential shared widget could have property to configure this anyway...
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-disk-utility/issues/68.