GNOME Bugzilla – Bug 787210
Allow skipping compilation of examples
Last modified: 2018-02-15 21:17:34 UTC
Created attachment 359018 [details] [review] disable demos build configure switch In Gentoo we want to properly control build dependencies as a rolling release distribution could not work without it. In libgdata, gtk+ presence is detected but not controllable in order to build examples. The attached patch allows disabling examples build while keeping the current default.
Review of attachment 359018 [details] [review]: I’d prefer an --enable-gtk+ option which defines an ENABLE_GTK variable to replace the existing HAVE_GTK condition in Makefile.am. There’s no point in disabling compilation of all the non-GTK+ demos.
Fixed in master with an approach similar to what I suggested in comment #1. commit 40e3eefae8e2d03d549d0f26862d0e2e0883d6c9 (HEAD -> master, origin/master, origin/HEAD) Author: Philip Withnall <withnall@endlessm.com> Date: Wed Feb 14 16:15:15 2018 +0000 build: Add --enable-gtk option to conditionalise GTK+ examples Only build the GTK+ examples if enabled explicitly with --enable-gtk, or if --enable-gtk is not specified and GTK+ is available. Signed-off-by: Philip Withnall <withnall@endlessm.com> https://bugzilla.gnome.org/show_bug.cgi?id=787210 Makefile.am | 3 ++- configure.ac | 12 ++++++++++-- 2 files changed, 12 insertions(+), 3 deletions(-)
Yeah my patch was a bit biased as package maintainers don't need demos, examples and whatnot to build by default as it won't be used in the package. We generally ship demos or examples source files only in doc/examples.