After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787166 - Unbalanced G_GNUC_BEGIN_IGNORE_DEPRECATIONS use in soup-session.c
Unbalanced G_GNUC_BEGIN_IGNORE_DEPRECATIONS use in soup-session.c
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: Misc
2.59.x
Other Linux
: Normal minor
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2017-09-02 09:04 UTC by Zan Dobersek
Modified: 2017-10-02 12:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (1.10 KB, patch)
2017-09-02 09:19 UTC, Zan Dobersek
committed Details | Review

Description Zan Dobersek 2017-09-02 09:04:13 UTC
In soup_session_remove_feature_by_type(), the G_GNUC_BEGIN_IGNORE_DEPRECATIONS macro is used, but is a few lines later used again in place of the complementary G_GNUC_END_IGNORE_DEPRECATIONS.
Comment 1 Zan Dobersek 2017-09-02 09:19:08 UTC
Created attachment 358971 [details] [review]
Patch

Replaces the second G_GNUC_BEGIN_IGNORE_DEPRECATIONS with G_GNUC_END_IGNORE_DEPRECATIONS.
Comment 2 Carlos Garcia Campos 2017-10-02 09:27:15 UTC
Comment on attachment 358971 [details] [review]
Patch

Good catch! Dan, this is trivial fix, so I'm approving this.