GNOME Bugzilla – Bug 787154
main-window: Add explanatory tooltips to buttons
Last modified: 2017-10-28 19:33:03 UTC
These are nice to have for anyone, and might be essential for a11y.
Created attachment 358959 [details] [review] main-window: Add explanatory tooltips to buttons
(In reply to Daniel Boles from comment #0) > [...] might be essential for a11y. No, it's not essential (or relevant) for a11y, as both buttons already have an accessible name. As I understand, tooltips are discouraged nowadays, but I don't particular mind them if Bastian agrees. I do think the join-button's accessible name is better than the proposed tooltip though (pus re-using the existing string means there's no string break involved)
(In reply to Florian Müllner from comment #2) > No, it's not essential (or relevant) for a11y, as both buttons already have > an accessible name. Indeed, thanks. > As I understand, tooltips are discouraged nowadays Really? I hope not. If so, that's bizarre to me. I don't need them for a11y, but I do like to have discoverability and to avoid surprises. So, I prefer programs that - if they insist on using images for buttons and whatnot - at least give me a way to figure out what that button's going to do without clicking on it, potentially fatally (yes, I know about ".destructive-action", but still). Not all icons can be 100% obvious all the time, and we have some that are almost completely inscrutable. > do think the join-button's accessible name is > better than the proposed tooltip though (pus re-using the existing string > means there's no string break involved) Sure, that makes sense. What about the user list button? It has no AtkObject, first and foremost. Secondarily, would you prefer a longer, sentence-case description than my earlier "User List" in either the a11y or tooltip cases?
Created attachment 358978 [details] [review] main-window: Add tooltip to Join button Use the same string as the accessible name, to aid translators.
Created attachment 358979 [details] [review] main-window: Add accessible/tooltip to user button It was lacking both.
Review of attachment 358979 [details] [review]: There is no point in setting an accessible name in the .ui file that is always overridden from code (see userList.js)
Thanks for the correction. I couldn't see where that was done... another hint would be appreciated! How about Attachment 358978 [details]?
(In reply to Daniel Boles from comment #7) > Thanks for the correction. I couldn't see where that was done... another > hint would be appreciated! Ah yes, sorry - not userList.js but here: https://git.gnome.org/browse/polari/tree/src/mainWindow.js#n375 > How about Attachment 358978 [details]? If Bastian is fine with adding tooltips, then the patch looks good to me. It doesn't break the string freeze, so it would be possible to push it after 3.26.0 is released, however I don't like the idea of adding one tooltip in 3.26 and the other one in 3.28. I don't think there's a string we can reuse for the user-list button, so that tooltip will need a string freeze break if we want it in 3.26 ...
(In reply to Florian Müllner from comment #8) > Ah yes, sorry - not userList.js but here: > https://git.gnome.org/browse/polari/tree/src/mainWindow.js#n375 Great, thanks! > I don't think there's a string we can reuse > for the user-list button, so that tooltip will need a string freeze break if > we want it in 3.26 ... I'm not in a rush if you're not! It'd just be nice to get them in at some point. > > How about Attachment 358978 [details]? > > If Bastian is fine with adding tooltips, then the patch looks good to me. It > doesn't break the string freeze, so it would be possible to push it after > 3.26.0 is released, however I don't like the idea of adding one tooltip in > 3.26 and the other one in 3.28. Sure, it makes more sense to keep them together, whenever they end up landing.
Created attachment 359671 [details] [review] main-window: Add tooltip to user list button -- I thought of a few different strings, but this seemed like a good combination of concise vs descriptive. Of course, someone else probably has a better one!
Review of attachment 359671 [details] [review]: "Show info" sounds a bit too colloquial IMHO, I'll go with "Show connected users" instead ...
Attachment 358978 [details] pushed as 9dfa989 - main-window: Add tooltip to Join button Attachment 359671 [details] pushed as b9d2f7a - main-window: Add tooltip to user list button