GNOME Bugzilla – Bug 787153
toolbar: Add explanatory tooltips to buttons
Last modified: 2017-09-17 16:13:34 UTC
These are nice to have for anyone, and might be essential for a11y.
Created attachment 358958 [details] [review] toolbar: Add explanatory tooltips to buttons
Review of attachment 358958 [details] [review]: Thanks! One question: isn’t sentence capitalization more appropriate for tooltips? ::: src/resources/ui/nautilus-toolbar.ui @@ +163,3 @@ <property name="visible">False</property> <property name="popover">operations_popover</property> + <property name="tooltip-text" translatable="yes">Operations</property> I think that “Show operations” would indeed fit better here.
> isn’t sentence capitalization more appropriate for tooltips? I noticed after that Nautilus preferred this, but it's unclear to me. Relative to the HIG, * to me, such tooltips are titles/'headings' for the buttons, hence title-case? * but they happen to be grammatically self-contained too, hence sentence case? The HIG doesn't seem to address tooltips specifically. There are other situations where it seems to enforce case by widget - e.g. * menu items, like the PlacesSidebar's "Open in New _Tab", already in Nautilus * or the new GtkEntry "Insert Emoji" in menu, which we copied to the tooltip - but tooltips do not seem to be so clear-cut. In the case of menu items, it lumps them in with labels that are 'not usually complete sentences', but that seems to apply even if they are (or could be, when read as commands to the app). Anyway, I guess I should just follow what Nautilus normally does, by using sentence case - and you can have the larger debate about capitalisation another time. :P
(In reply to Daniel Boles from comment #3) > > isn’t sentence capitalization more appropriate for tooltips? > > I noticed after that Nautilus preferred this, but it's unclear to me. > Relative to the HIG, > * to me, such tooltips are titles/'headings' for the buttons, hence > title-case? > * but they happen to be grammatically self-contained too, hence sentence > case? > > The HIG doesn't seem to address tooltips specifically. There are other > situations where it seems to enforce case by widget - e.g. > * menu items, like the PlacesSidebar's "Open in New _Tab", already in > Nautilus > * or the new GtkEntry "Insert Emoji" in menu, which we copied to the tooltip > - but tooltips do not seem to be so clear-cut. In the case of menu items, it > lumps them in with labels that are 'not usually complete sentences', but > that seems to apply even if they are (or could be, when read as commands to > the app). > > Anyway, I guess I should just follow what Nautilus normally does, by using > sentence case - and you can have the larger debate about capitalisation > another time. :P Looking at the HIG from the glorious 2.x days, it seems to suggest sentence capitalization, but I’m not sure how much of it still applies.
Created attachment 358977 [details] [review] toolbar: Add explanatory tooltips to buttons These are nice to have for anyone and might also help with a11y.
Review of attachment 358977 [details] [review]: LGTM
Comment on attachment 358977 [details] [review] toolbar: Add explanatory tooltips to buttons Thanks. Since it looks like this can go in now, I'd appreciate if someone else can commit it, until I figure out what my gitlab account is, if I have one. :P
You don't need any GitLab account or any change, everything should work as before. Feel free to commit! :)
*tries* oh yeah! off to master it goes.
There is no gnome-3-26 yet, so you just broke the string freeze. :)
Review of attachment 358977 [details] [review]: ::: src/resources/ui/nautilus-toolbar.ui @@ +107,3 @@ <property name="sensitive">True</property> <property name="action_name">slot.files-view-mode-toggle</property> + <property name="tooltip-text" Vranslatable="yes">Toggle view</property> Oops.
hahaha... oh dear. Thanks for both of those! I thought I had checked and saw a 3.26 branch, then I obviously confused Carlos into approving it, and convinced myself. :P reverted by https://gitlab.gnome.org/GNOME/nautilus/commit/1cdbecd1625bc433679d0c3758ddcc4a40f46cbb
Nautilus has branched for gnome-3-26, so master is unfrozen.
Attachment 358977 [details] pushed as 6649444 - toolbar: Add explanatory tooltips to buttons committed with the typo fixed. Thanks for the reminder!