After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787117 - /tls/certificate_verify_success_with_full_chain test fails on x86 32bits
/tls/certificate_verify_success_with_full_chain test fails on x86 32bits
Status: RESOLVED OBSOLETE
Product: empathy
Classification: Core
Component: General
3.25.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2017-09-01 10:59 UTC by Laurent Bigonville
Modified: 2018-05-22 19:18 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Laurent Bigonville 2017-09-01 10:59:34 UTC
Hi,

In debian I enabled the checks at build time and /tls/certificate_verify_success_with_full_chain is failing on 32bits and/or bigendian architectures

https://buildd.debian.org/status/package.php?p=empathy&suite=unstable

Valgrind shows:

/tls/certificate_verify_success_with_full_chain: ==12616== Invalid read of size 4
==12616==    at 0x57AE167: g_array_ref (garray.c:259)
==12616==    by 0x57AF7A7: g_byte_array_ref (garray.c:1762)
==12616==    by 0x573F94A: boxed_proxy_collect_value (gboxed.c:240)
==12616==    by 0x574A0AA: g_object_new_valist (gobject.c:2090)
==12616==    by 0x55A9608: g_initable_new_valist (ginitable.c:244)
==12616==    by 0x55A966B: g_initable_new (ginitable.c:162)
==12616==    by 0x4961A3B: tls_certificate_new_from_der (empathy-tls-verifier.c:80)
==12616==    by 0x4961A3B: is_certificate_pinned_cb (empathy-tls-verifier.c:288)
==12616==    by 0x55C366F: g_simple_async_result_complete (gsimpleasyncresult.c:801)
==12616==    by 0x55C3727: complete_in_idle_cb_for_thread (gsimpleasyncresult.c:872)
==12616==    by 0x57DCA83: g_main_dispatch (gmain.c:3148)
==12616==    by 0x57DCA83: g_main_context_dispatch (gmain.c:3813)
==12616==    by 0x57DCE98: g_main_context_iterate.isra.30 (gmain.c:3886)
==12616==    by 0x57DD248: g_main_loop_run (gmain.c:4082)
==12616==    by 0x10C6F5: test_certificate_verify_success_with_full_chain (empathy-tls-test.c:508)
==12616==    by 0x5803D3E: test_case_run (gtestutils.c:2163)
==12616==    by 0x5803D3E: g_test_run_suite_internal (gtestutils.c:2247)
==12616==    by 0x5803C6A: g_test_run_suite_internal (gtestutils.c:2259)
==12616==    by 0x5803F08: g_test_run_suite (gtestutils.c:2332)
==12616==    by 0x5803F6C: g_test_run (gtestutils.c:1600)
==12616==    by 0x10B88B: main (empathy-tls-test.c:768)
==12616==  Address 0xee14564 is 0 bytes after a block of size 20 alloc'd
==12616==    at 0x482E2BC: malloc (vg_replace_malloc.c:299)
==12616==    by 0x57E1F88: g_malloc (gmem.c:94)
==12616==    by 0x57FA159: g_slice_alloc (gslice.c:1025)
==12616==    by 0x57B63F1: g_bytes_new_with_free_func (gbytes.c:184)
==12616==    by 0x57B6443: g_bytes_new_take (gbytes.c:126)
==12616==    by 0x57B64B2: g_bytes_new (gbytes.c:96)
==12616==    by 0x4B379B4: tls_certificate_got_all_cb (tls-certificate.c:274)
==12616==    by 0x4B24952: _tp_cli_properties_interface_invoke_callback_list_properties (tp-cli-generic-body.h:1852)
==12616==    by 0x4B2A35F: tp_proxy_pending_call_idle_invoke (proxy-methods.c:156)
==12616==    by 0x57DCA83: g_main_dispatch (gmain.c:3148)
==12616==    by 0x57DCA83: g_main_context_dispatch (gmain.c:3813)
==12616==    by 0x57DCE98: g_main_context_iterate.isra.30 (gmain.c:3886)
==12616==    by 0x57DD248: g_main_loop_run (gmain.c:4082)
==12616==    by 0x10BC71: ensure_certificate_proxy (empathy-tls-test.c:405)
==12616==    by 0x10C6BE: test_certificate_verify_success_with_full_chain (empathy-tls-test.c:502)
==12616==    by 0x5803D3E: test_case_run (gtestutils.c:2163)
==12616==    by 0x5803D3E: g_test_run_suite_internal (gtestutils.c:2247)
==12616==    by 0x5803C6A: g_test_run_suite_internal (gtestutils.c:2259)
==12616==    by 0x5803F08: g_test_run_suite (gtestutils.c:2332)
==12616==    by 0x5803F6C: g_test_run (gtestutils.c:1600)
==12616==    by 0x10B88B: main (empathy-tls-test.c:768)
Comment 1 Laurent Bigonville 2017-09-01 11:02:48 UTC


  • #0 0x00000020 in
  • #1 array_free
    at ../../../../glib/garray.c line 363
  • #2 g_byte_array_unref
    at ../../../../glib/garray.c line 1779
  • #3 boxed_proxy_value_free
    at ../../../../gobject/gboxed.c line 205
  • #4 g_value_unset
    at ../../../../gobject/gvalue.c line 275
  • #5 g_object_new_valist
    at ../../../../gobject/gobject.c line 2107
  • #6 g_initable_new_valist
    at ../../../../gio/ginitable.c line 244
  • #7 g_initable_new
    at ../../../../gio/ginitable.c line 162
  • #8 tls_certificate_new_from_der
    at empathy-tls-verifier.c line 80
  • #9 is_certificate_pinned_cb
    at empathy-tls-verifier.c line 288
  • #10 g_simple_async_result_complete
    at ../../../../gio/gsimpleasyncresult.c line 801
  • #11 complete_in_idle_cb_for_thread
    at ../../../../gio/gsimpleasyncresult.c line 872
  • #12 g_main_dispatch
    at ../../../../glib/gmain.c line 3148
  • #13 g_main_context_dispatch
    at ../../../../glib/gmain.c line 3813
  • #14 g_main_context_iterate
    at ../../../../glib/gmain.c line 3886
  • #15 g_main_loop_run
    at ../../../../glib/gmain.c line 4082
  • #16 test_certificate_verify_success_with_full_chain
    at empathy-tls-test.c line 508
  • #17 test_case_run
    at ../../../../glib/gtestutils.c line 2163
  • #18 g_test_run_suite_internal
    at ../../../../glib/gtestutils.c line 2247
  • #19 g_test_run_suite_internal
    at ../../../../glib/gtestutils.c line 2259
  • #20 g_test_run_suite
    at ../../../../glib/gtestutils.c line 2335
  • #21 g_test_run
    at ../../../../glib/gtestutils.c line 1600
  • #22 main
    at empathy-tls-test.c line 768

Comment 2 GNOME Infrastructure Team 2018-05-22 19:18:53 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/904.