After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787113 - Fix testLegacyGObject importing the GTK overrides
Fix testLegacyGObject importing the GTK overrides
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
1.49.x
Other All
: Normal minor
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2017-09-01 04:31 UTC by Philip Chimento
Modified: 2017-09-02 03:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests: Split legacy Gtk.Widget tests out (9.44 KB, patch)
2017-09-01 04:32 UTC, Philip Chimento 		committed Details | Review

Description Philip Chimento 2017-09-01 04:31:36 UTC 
Spotted on bug 786995, testLegacyGObject has tests in it that require the GTK dependency.
Comment 1 Philip Chimento 2017-09-01 04:32:47 UTC 
Created attachment 358913 [details] [review]
tests: Split legacy Gtk.Widget tests out

This creates a new test file, testLegacyGtk.js, which is only run if the
GTK dependency is present.
Comment 2 Cosimo Cecchi 2017-09-01 16:43:40 UTC 
Review of attachment 358913 [details] [review]:

OK
Comment 3 Philip Chimento 2017-09-02 03:55:45 UTC 
Attachment 358913 [details] pushed as e5afef1 - tests: Split legacy Gtk.Widget tests out