GNOME Bugzilla – Bug 787094
Port to meson build system
Last modified: 2018-01-23 10:15:31 UTC
Port to meson build system.
Created attachment 358876 [details] [review] Updated autotools to use libgd module at subproject directory This patch updates libgd module location from source root to subprojects directory, which helps porting to meson.
Created attachment 358877 [details] [review] Modified photos-generate-about script The 'photos-generate-about' script does not fully create the 'body' source code as it doesn't include the header file, which is done through the Makefile file. This patch modifies the script to fully reate the 'body' by also including the header file, which helps porting to meson.
Created attachment 358880 [details] [review] Port to meson build system Patch that adds meson build system along autotools. It does use a developer version of meson (0.43.0), which includes 'annotate' option support for gdbus-codegen that is used to generate 'photos-thumbnailer-dbus.[ch]' and 'photos-dleyna-renderer-device.[ch]' files. Although autotools seems to set 'HAVE_SHM_OPEN' define in the config.h file, the guard used for this is based on the 'EGG_COUNTER_DISABLE_SHM' environment variable, which makes the 'shm_open' function mandatory. Finally, although tests are installed were they are expected to be, and although they seem to work (and pass) here, I'm not totally sure about their environment variable setup, as glib-tap.mk makes (and setups) a lot of things.
Created attachment 358881 [details] [review] Remove autotools Some applications are removing autotools to avoid the burden of maintaining two build systems. This patch removes autotools in case it is considered.
Finally, I have created a wip branch[0] to ease it's testing. Any suggestion would be very much appreciated. https://git.gnome.org/browse/gnome-photos/log/?h=wip/inigomartinez/meson
Thanks for the patches. Since we are in the freezes for GNOME 3.26, it is probably best to merge these early in the next cycle.
Created attachment 359164 [details] [review] Updated autotools to use libgd module at subproject directory
Created attachment 359165 [details] [review] Modified photos-generate-about script
Created attachment 359166 [details] [review] Port to meson build system
Created attachment 359167 [details] [review] Remove autotools
All the patches concerning meson build port have been updated after the migration of autotools to modern Gettext[0]. Now it uses meson's i18n module to use gettext instead of 'custom_targets' to call 'intltool'. [0] https://bugzilla.gnome.org/show_bug.cgi?id=787105
Created attachment 359175 [details] [review] Updated autotools to use libgd module at subproject directory Included bug URL in the patch.
Created attachment 359176 [details] [review] Modified photos-generate-about script Included bug URL in the patch.
Created attachment 359177 [details] [review] Port to meson build system - Included bug URL in the patch. - Bumped the version number. - Changed the way icons, schemas and desktop files holding directories are passed to the post install script.
Created attachment 359178 [details] [review] Remove autotools Included bug URL in the patch.
Created attachment 359649 [details] [review] Move libgd module The patch subject has been changed to better express what it does.
Created attachment 359650 [details] [review] Modify photos-generate-about script The patch subject has been changed to better express what it does.
Created attachment 359651 [details] [review] Port to meson build system The code has been updated to the 3.27.1 version. The version number has also been changed accordingly. The commit message has also been changed to explain what it is about.
Created attachment 359652 [details] [review] Remove autotools The patch has been updated following the changes of the last port to meson build patch update. The commit message has also been changed to explain what it does and why.
The wip branch[0] has also been updated with all the recent changes. [0] https://git.gnome.org/browse/gnome-photos/log/?h=wip/inigomartinez/meson
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-photos/issues/71.