After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787057 - outdated warning about seccomp in configure.ac
outdated warning about seccomp in configure.ac
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: tracker-general
tracker-general
Depends on:
Blocks:
 
 
Reported: 2017-08-31 06:48 UTC by Michael Biebl
Modified: 2017-08-31 09:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] build: Drop obsolete warning about seccomp (638 bytes, patch)
2017-08-31 09:02 UTC, Michael Biebl
accepted-commit_now Details | Review
[PATCH 2/2] build: Drop obsolete _REQUIRED versions (1.15 KB, patch)
2017-08-31 09:10 UTC, Michael Biebl
accepted-commit_now Details | Review

Description Michael Biebl 2017-08-31 06:48:25 UTC
Version: 1.99.2

After the split of the miners from the tracker sources, tracker itself does not make use of (lib)seccomp anymore. The corresponding configure check was removed.

Seems there is a leftover warning though which should also be removed:

======================================
if test "$have_libseccomp" = "no"; then
echo "
WARNING: libseccomp was not found, build will not be prevented, but this is a security flaw.
"
fi
======================================

This will always be true, so one gets a useless/confusing warning message during configure.
Comment 1 Michael Biebl 2017-08-31 09:02:53 UTC
Created attachment 358832 [details] [review]
[PATCH] build: Drop obsolete warning about seccomp
Comment 2 Michael Biebl 2017-08-31 09:10:39 UTC
Created attachment 358833 [details] [review]
[PATCH 2/2] build: Drop obsolete _REQUIRED versions

While at it, I noticed that configure.ac has lots of obsolete FOO_REQUIRED versions after the split. The second patch drops those.

I didn't bother touching the meson build system, as it looks severely out of date.
Comment 3 Carlos Garnacho 2017-08-31 09:19:21 UTC
> I didn't bother touching the meson build system, as it looks severely out of
> date.

FWIW, that's non intentional. https://github.com/mesonbuild/meson/issues/2166 is a showstopper but tracker should still seamlessly build from git with meson.
Comment 4 Carlos Garnacho 2017-08-31 09:20:59 UTC
Comment on attachment 358832 [details] [review]
[PATCH] build: Drop obsolete warning about seccomp

Looks good. Thanks!
Comment 5 Michael Biebl 2017-08-31 09:22:05 UTC
(In reply to Carlos Garnacho from comment #3)
> > I didn't bother touching the meson build system, as it looks severely out of
> > date.
> 
> FWIW, that's non intentional.
> https://github.com/mesonbuild/meson/issues/2166 is a showstopper but tracker
> should still seamlessly build from git with meson.

Personally I wouldn't bother with shipping pre-generated documentation in the dist tarball. In Debian I regenerate them anyway. For other distros it's probably not a huge deal either to pull in the necessary dependencies to build the docs.
Comment 6 Carlos Garnacho 2017-08-31 09:22:44 UTC
Comment on attachment 358833 [details] [review]
[PATCH 2/2] build: Drop obsolete _REQUIRED versions

LGTM.
Comment 7 Michael Biebl 2017-08-31 09:24:21 UTC
Pushed to git master. Thanks for the review
Comment 8 Carlos Garnacho 2017-08-31 09:27:08 UTC
Thanks!

(In reply to Michael Biebl from comment #5)
> Personally I wouldn't bother with shipping pre-generated documentation in
> the dist tarball. In Debian I regenerate them anyway. For other distros it's
> probably not a huge deal either to pull in the necessary dependencies to
> build the docs.

I don't need it for docs, but for generating the tracker-parser-sha1.h file to 1) offer one way rebuild the FTS table on tokenizer code changes, and 2) avoid those happen too often needlessly.

More info at https://github.com/mesonbuild/meson/issues/2166#issuecomment-322036309