GNOME Bugzilla – Bug 787057
outdated warning about seccomp in configure.ac
Last modified: 2017-08-31 09:27:08 UTC
Version: 1.99.2 After the split of the miners from the tracker sources, tracker itself does not make use of (lib)seccomp anymore. The corresponding configure check was removed. Seems there is a leftover warning though which should also be removed: ====================================== if test "$have_libseccomp" = "no"; then echo " WARNING: libseccomp was not found, build will not be prevented, but this is a security flaw. " fi ====================================== This will always be true, so one gets a useless/confusing warning message during configure.
Created attachment 358832 [details] [review] [PATCH] build: Drop obsolete warning about seccomp
Created attachment 358833 [details] [review] [PATCH 2/2] build: Drop obsolete _REQUIRED versions While at it, I noticed that configure.ac has lots of obsolete FOO_REQUIRED versions after the split. The second patch drops those. I didn't bother touching the meson build system, as it looks severely out of date.
> I didn't bother touching the meson build system, as it looks severely out of > date. FWIW, that's non intentional. https://github.com/mesonbuild/meson/issues/2166 is a showstopper but tracker should still seamlessly build from git with meson.
Comment on attachment 358832 [details] [review] [PATCH] build: Drop obsolete warning about seccomp Looks good. Thanks!
(In reply to Carlos Garnacho from comment #3) > > I didn't bother touching the meson build system, as it looks severely out of > > date. > > FWIW, that's non intentional. > https://github.com/mesonbuild/meson/issues/2166 is a showstopper but tracker > should still seamlessly build from git with meson. Personally I wouldn't bother with shipping pre-generated documentation in the dist tarball. In Debian I regenerate them anyway. For other distros it's probably not a huge deal either to pull in the necessary dependencies to build the docs.
Comment on attachment 358833 [details] [review] [PATCH 2/2] build: Drop obsolete _REQUIRED versions LGTM.
Pushed to git master. Thanks for the review
Thanks! (In reply to Michael Biebl from comment #5) > Personally I wouldn't bother with shipping pre-generated documentation in > the dist tarball. In Debian I regenerate them anyway. For other distros it's > probably not a huge deal either to pull in the necessary dependencies to > build the docs. I don't need it for docs, but for generating the tracker-parser-sha1.h file to 1) offer one way rebuild the FTS table on tokenizer code changes, and 2) avoid those happen too often needlessly. More info at https://github.com/mesonbuild/meson/issues/2166#issuecomment-322036309