After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787054 - When the number of occurrences is set to 1, consider the event as non recurring
When the number of occurrences is set to 1, consider the event as non recurring
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: General
3.25.x
Other Linux
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-31 02:59 UTC by Mohammed Sadiq
Modified: 2017-09-12 14:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
It sets the minimum value of spin button as 2. (819 bytes, patch)
2017-09-12 03:23 UTC, Nidhi Gupta 		none Details | Review
It sets the minimum value of recurrence as 2. Made the changes as asked. (1006 bytes, patch)
2017-09-12 06:34 UTC, Nidhi Gupta 		none Details | Review
Updated commit message (1004 bytes, patch)
2017-09-12 06:44 UTC, Nidhi Gupta 		none Details | Review
Set the minimum value of recurrence spin button as 2 (1.02 KB, patch)
2017-09-12 07:09 UTC, Nidhi Gupta 		none Details | Review
It sets the minimum value of recurrence as 2. Updated commit message. (1.05 KB, patch)
2017-09-12 14:10 UTC, Nidhi Gupta 		committed Details | Review

Description Mohammed Sadiq 2017-08-31 02:59:04 UTC 
It would be nice when an event is set to have number of occurrences to be 1, save it as non-recurring event.
Comment 1 Mohammed Sadiq 2017-08-31 03:01:24 UTC 
Or alternatively and even better way to do it would be to set the minimum value of the Number of recurrences spin button to 2.
Comment 2 Nidhi Gupta 2017-09-12 03:23:59 UTC 
Created attachment 359567 [details] [review]
It sets the minimum value of spin button as 2.
Comment 3 Mohammed Sadiq 2017-09-12 03:47:56 UTC 
Review of attachment 359567 [details] [review]:

Hi,
   The code looks good. Though the following minor improvements to patch is required:
* Set the Author name and email. Right now it is some garbage
* Improve commit message:
  You don't require to include the whole file name (Also, as gcal is common, you may better avoid it). So you can replace gcal-edit-dialog.c with edit-dialog. (Different projects have different rules. So you might find a different style for some other project). Insert a space after colon
An improvement to commit message is also desirable.
* Also Include the url of the bug in the patch.

Please see https://wiki.gnome.org/Newcomers/SubmitPatch

Thanks
Comment 4 Nidhi Gupta 2017-09-12 06:34:44 UTC 
Created attachment 359580 [details] [review]
It sets the minimum value of recurrence as 2. Made the changes as asked.
Comment 5 Nidhi Gupta 2017-09-12 06:44:35 UTC 
Created attachment 359581 [details] [review]
Updated commit message
Comment 6 Nidhi Gupta 2017-09-12 07:09:53 UTC 
Created attachment 359583 [details] [review]
Set the minimum value of recurrence spin button as 2
Comment 7 Nidhi Gupta 2017-09-12 14:10:54 UTC 
Created attachment 359636 [details] [review]
It sets the minimum value of recurrence as 2. Updated commit message.
Comment 8 Mohammed Sadiq 2017-09-12 14:41:20 UTC 
Thanks. Pushed with minor changes.
Comment 9 Mohammed Sadiq 2017-09-12 14:48:15 UTC 
pushed to a5d1d9d