After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787050 - test image is distributable but not free
test image is distributable but not free
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks:
 
 
Reported: 2017-08-31 02:26 UTC by Jeremy Bicha
Modified: 2017-09-19 22:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
replacement image (58.21 KB, application/octet-stream)
2017-09-19 05:15 UTC, Olly Betts
  Details
Replacement image (144.33 KB, image/png)
2017-09-19 05:20 UTC, Olly Betts
  Details
tests: Replace non-free "lena" reference image (653.74 KB, patch)
2017-09-19 09:20 UTC, Bastien Nocera
committed Details | Review

Description Jeremy Bicha 2017-08-31 02:26:38 UTC
gdk-pixbuf 2.36.9

Debian's Lintian checker flagged these 2 files:
tests/test-images/reftests/lena.jpg
tests/test-images/reftests/lena.jpg.ref.png

Here's a link with more information about the issue:
https://lintian.debian.org/tags/license-problem-non-free-img-lenna.html
Comment 1 Bastien Nocera 2017-09-04 17:43:26 UTC
A patch would be nice.
Comment 2 Olly Betts 2017-09-19 05:15:23 UTC
Created attachment 360021 [details]
replacement image
Comment 3 Olly Betts 2017-09-19 05:20:22 UTC
Created attachment 360022 [details]
Replacement image

Replacement images attached - just copy both into tests/test-images/reftests/ and remove the lena images from there.  I've tested by doing that in current git master (24794b086cc4b7f78d4a45786d66368b44ffc8de) and running "make check", and the tests still pass (and looking at the testsuite logs, the new image was used).

I've attempted to make the replacements match the lena images:

$ file tests/test-images/reftests/{cat,lena}.jpg* 
tests/test-images/reftests/cat.jpg:          JPEG image data, JFIF standard 1.01, resolution (DPI), density 72x72, segment length 16, baseline, precision 8, 512x512, frames 1
tests/test-images/reftests/cat.jpg.ref.png:  PNG image data, 512 x 512, 8-bit/color RGB, non-interlaced
tests/test-images/reftests/lena.jpg:         JPEG image data, JFIF standard 1.01, resolution (DPI), density 72x72, segment length 16, baseline, precision 8, 512x512, frames 1
tests/test-images/reftests/lena.jpg.ref.png: PNG image data, 512 x 512, 8-bit/color RGB, non-interlaced
Comment 4 Olly Betts 2017-09-19 05:26:47 UTC
Licensing-wise, I took the photo and am making it available under CC0 (https://directory.fsf.org/wiki/License:CC0) - if something else is more helpful, please just ask.
Comment 5 Bastien Nocera 2017-09-19 09:20:26 UTC
Created attachment 360032 [details] [review]
tests: Replace non-free "lena" reference image
Comment 6 Bastien Nocera 2017-09-19 09:21:29 UTC
Attachment 360032 [details] pushed as 53ffd56 - tests: Replace non-free "lena" reference image
Comment 7 Olly Betts 2017-09-19 22:44:22 UTC
Thanks for applying so promptly, and sorry for not providing a binary patch - I wasn't aware of `git diff --binary` previously.