After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787011 - AdBlock blocks entire web pages
AdBlock blocks entire web pages
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-30 10:10 UTC by Bastien Nocera
Modified: 2017-08-31 09:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Adblocker must not block main resource during redirects (2.56 KB, patch)
2017-08-31 01:53 UTC, Michael Catanzaro 		committed Details | Review

Description Bastien Nocera 2017-08-30 10:10:22 UTC 
epiphany-3.25.91-1.fc28.x86_64

I cannot click on eBay emails that would take me to their messaging section of the site when the ad-blocker is enabled. Disabling the adblocker makes the messaging page show up correctly.

I can share the email privately, or message with somebody who's interested in fixing this problem if they have an account.

See also bug 617944
Comment 1 Michael Catanzaro 2017-08-31 01:53:35 UTC 
This fixes the link in the eBay email you sent me, and also DuckDuckGo ads.

The following fix has been pushed:
f808d22 Adblocker must not block main resource during redirects
Comment 2 Michael Catanzaro 2017-08-31 01:53:38 UTC 
Created attachment 358808 [details] [review]
Adblocker must not block main resource during redirects

Our logic to avoid blocking the main resource doesn't work during
redirects.

Also, move the GSettings check inside our helper function.
Comment 3 Bastien Nocera 2017-08-31 09:31:32 UTC 
That works, thanks!