After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786993 - nvdec: build broken after GL/gl.h no longer included
nvdec: build broken after GL/gl.h no longer included
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-29 23:50 UTC by Per-Erik Brodin
Modified: 2017-08-31 07:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (799 bytes, patch)
2017-08-29 23:53 UTC, Per-Erik Brodin 		committed Details | Review
build error (3.28 KB, text/plain)
2017-08-30 17:56 UTC, Per-Erik Brodin 		  Details

Description Per-Erik Brodin 2017-08-29 23:50:19 UTC 
Should include gstglfuncs.h
Comment 1 Per-Erik Brodin 2017-08-29 23:53:40 UTC 
Created attachment 358732 [details] [review]
patch
Comment 2 Sebastian Dröge (slomo) 2017-08-30 06:37:41 UTC 
commit f2674517518f14eab08d804562e5a746ff06337c (HEAD -> master)
Author: Per-Erik Brodin <per-erik.brodin@ericsson.com>
Date:   Tue Aug 29 16:52:07 2017 -0700

    nvdec: fix build after GL/gl.h no longer included
    
    GL headers are no longer included in public gstgl headers, except for
    gstglfuncs.h so make sure to include that one.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=786993
Comment 3 Julien Isorce 2017-08-30 09:47:01 UTC 
Hi Per-Erik, what was the build error exactly ?

If it is just because of "GL_TEXTURE_2D" (when calling cuGraphicsGLRegisterImage), you can replace it by "gst_gl_texture_target_to_gl (GST_GL_TEXTURE_TARGET_2D)".
Comment 4 Per-Erik Brodin 2017-08-30 17:56:32 UTC 
Created attachment 358784 [details]
build error
Comment 5 Per-Erik Brodin 2017-08-30 17:57:33 UTC 
(In reply to Julien Isorce from comment #3)
> Hi Per-Erik, what was the build error exactly ?
> 
> If it is just because of "GL_TEXTURE_2D" (when calling
> cuGraphicsGLRegisterImage), you can replace it by
> "gst_gl_texture_target_to_gl (GST_GL_TEXTURE_TARGET_2D)".

cudaGL.h is using GLuint in several places and the function prototype for cuGraphicsGLRegisterImage is using GLenum for the texture target.
http://manpages.ubuntu.com/manpages/zesty/man3/cudaGL.h.3.html
Comment 6 Julien Isorce 2017-08-31 07:57:00 UTC 
Ack, thx.