GNOME Bugzilla – Bug 786991
gtkglsink: add "rotate-method" property
Last modified: 2018-11-03 15:21:34 UTC
This should match the capabilities of glimagesink, this includes support for the AffineTransformationMeta and the image-orientation tag as well as manual rotation using the property. I didn't do it in glsinkbin becausse the GL happens in the GTK thread in that case.
Created attachment 358730 [details] [review] glutils: Export affine transmortation functions for gtkglsink
Created attachment 358731 [details] [review] gtkglsink: Add rotate-method property This mostly just takes code out of glimagesink and applies it here.
Review of attachment 358730 [details] [review]: The symbols in _private.h should be moved to the non-private header if they are to be exported. The _private.h header is not installed. Should also remove the duplicated symbols in ext/gl/gstglutils.c if you want to do this.
Review of attachment 358731 [details] [review]: Looks mostly ok. ::: ext/gtk/gstgtkglsink.c @@ +392,3 @@ + if (!g_strcmp0 ("rotate-0", orientation)) + gtk_gst_gl_widget_set_rotate_method (GTK_GST_GL_WIDGET + (gst_gtk_base_sink_acquire_widget (GST_GTK_BASE_SINK (sink))), Erm, could you retrieve the widget earlier and make this line (and subsequent lines) a lot shorter please. ::: ext/gtk/gtkgstglwidget.c @@ +31,3 @@ +#include <gst/video/gstvideoaffinetransformationmeta.h> +#include <gst/gl/gstglutils.h> +#include <gst/gl/gstglutils_private.h> Private header.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/397.