After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786983 - Please make the output of gio-querymodules deterministic
Please make the output of gio-querymodules deterministic
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2017-08-29 15:48 UTC by Chris Lamb
Modified: 2017-10-02 10:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-gio-querymodules-Make-the-output-reproducible.patch (1.80 KB, patch)
2017-08-29 15:48 UTC, Chris Lamb
none Details | Review
358693: 0001-gio-querymodules-Make-the-output-reproducible.patch (1.54 KB, patch)
2017-08-29 16:01 UTC, Chris Lamb
committed Details | Review

Description Chris Lamb 2017-08-29 15:48:39 UTC
Created attachment 358693 [details] [review]
0001-gio-querymodules-Make-the-output-reproducible.patch

Whilst working on the Reproducible Builds effort [0], we noticed that
queryimmodules generates non-reproducible output as it iterates over the
filesystem without sorting.

Patch attached.

 [0] https://reproducible-builds.org/
Comment 1 Chris Lamb 2017-08-29 16:01:18 UTC
Created attachment 358694 [details] [review]
358693: 0001-gio-querymodules-Make-the-output-reproducible.patch

Let's try that again without the obvious debugging statement...
Comment 2 Philip Withnall 2017-09-08 14:20:04 UTC
Review of attachment 358694 [details] [review]:

Looks good, thanks.
Comment 3 Chris Lamb 2017-09-08 14:41:11 UTC
Thanks :)