GNOME Bugzilla – Bug 786969
Port to meson build system
Last modified: 2018-05-22 19:18:43 UTC
Created attachment 358669 [details] [review] Port to meson build system Port to meson build system of telepathy-account-widgets package. Although libraries are created properly, I have found several files pointing to files and locations that don't exist anymore. Coding style checks are also disabled because meson executes the scripts from unspecified location but check-c-style is expecting check-misc.sh to be located in the same directory and check-misc.sh is also expecting check-whitespace.sh to be located in the same directory. I don't know if this scripts are actually needed but they can be fixed to work with both build systems if needed.
I have created a wip branch to ease it's testing[0]. Any suggestion is very appreciated. [0] https://git.gnome.org/browse/telepathy-account-widgets/log/?h=wip/inigomartinez/meson
Review of attachment 358669 [details] [review]: As much as I like the ongoing migration to Meson, and your phenomenal effort towards that end, maybe we should just leave empathy alone? It is practically unmaintained and only sees very sporadic development activity. A port is likely to have some fallout which is likely to go unnoticed and may trick somebody down the line. I just don't see the benefits outweighing the costs here. It's not that the slowness of Autotools is wasting loads of developer time. I'd prefer to just leave empathy alone unless there is some urgent issue that needs fixing.
Thank you for your kind words, I understand perfectly what you say regarding any possible problem that may arise from porting this to meson. Actually, I didn't want to make any modifications to any of the "telepathy/empathy" components, as I don't know if they are unmaintained/deprecated. I started looking at "gnome-online-accounts", which I wanted to port meson, and I found that it used "telepathy-account-widgets" as a submodule. When porting some applications with submodules to meson, the fact that those submodules were already ported to meson, made porting easier and that's why I decided to also port "telepathy-account-widgets". Nevertheless, I started working with "gnome-online-accounts" just today, so maybe I should had looked it more in detail as this patch could be totally unnecessary.
(In reply to Iñigo Martínez from comment #3) > I understand perfectly what you say regarding any possible problem that may > arise from porting this to meson. Actually, I didn't want to make any > modifications to any of the "telepathy/empathy" components, as I don't know > if they are unmaintained/deprecated. I started looking at > "gnome-online-accounts", which I wanted to port meson, and I found that it > used "telepathy-account-widgets" as a submodule. > > [...] > > Nevertheless, I started working with "gnome-online-accounts" just today, so > maybe I should had looked it more in detail as this patch could be totally > unnecessary. Oh, I see. Yes, porting GOA to meson would be nice. Maybe this is just the excuse we need to drop the Telepathy support from GOA? Or maybe we should just give it one more cycle? *shrug* I'd definitely welcome ports for my other modules. eg., gnome-documents and gnome-photos. I recently ported gnome-documents away from intltool, so it should be easy.
Created attachment 359733 [details] [review] Port to meson build system When porting gnome-online-accounts to meson, although it's disabled there on purpose, the telepathy-account-widgets meson port needed some minor fixes. I know that tpaw probably will not need the meson port due to the problems of making huge changes to a deprecated library, but as it was almost complete I decided to make those minor changes. I'm including those changes in this patch update so they are not lost.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/903.